Test Laravel 12 #538
Merged
Test Laravel 12 #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
reviewed
Apr 17, 2025
| @@ -17,7 +17,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=7.2", | |||
| "php": "^8.1", | |||
There was a problem hiding this comment.
Bumping php version in a patch release is questionable. Should there be a security issue in 1.0.3, what version number would you use for a fix?
There was a problem hiding this comment.
PHP8.0 and below are not supported anymore by PHP, so I suggest that people who are still on 7.2-8.0 upgrade as soon as possible.
I also think it's a vary small change that a security fix will be required, as wkhtmltopdf is also EOL and this library is just a wrapper for Snappy which also only supports 8.1 and above, see https://github.com/KnpLabs/snappy/blob/master/composer.json
But otherwise I guess I could release 1.0.3.1 if required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.