-
Notifications
You must be signed in to change notification settings - Fork 231
Sudo Autocomplete #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sudo Autocomplete #1533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
damianhxy
commented
May 19, 2022
damianhxy
commented
May 19, 2022
damianhxy
commented
Jun 6, 2022
victorhuangwq
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested sudo autocomplete and it works as expected :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add autocomplete to Sudo page.
Also make sudo utilize user id instead of email, to facilitate reuse of autocomplete code between extension, submission, and sudo.
Description
Motivation and Context
As mentioned by Prof Iliano, it would be good to have autocomplete on the sudo page to easily select the correct user.
How Has This Been Tested?
(Same users from #1532)
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting