Skip to content

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented May 19, 2022

Add autocomplete to Sudo page.

Also make sudo utilize user id instead of email, to facilitate reuse of autocomplete code between extension, submission, and sudo.

Description

  • Add autocomplete logic to frontend
  • Add autocomplete logic to backend
  • Use cud id instead of email

Motivation and Context

As mentioned by Prof Iliano, it would be good to have autocomplete on the sudo page to easily select the correct user.

How Has This Been Tested?

(Same users from #1532)

  • Successfully sudoed and unsudoed each user, with no autocomplete display issues

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@damianhxy damianhxy marked this pull request as draft May 21, 2022 02:44
@damianhxy damianhxy marked this pull request as ready for review June 6, 2022 02:12
Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested sudo autocomplete and it works as expected :)

@damianhxy damianhxy merged commit 462f491 into master Jun 8, 2022
@damianhxy damianhxy deleted the sudo-autocomplete branch June 8, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants