Skip to content

Conversation

@agentran
Copy link
Contributor

Change list

Adding timeout to the activate app function

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

sometimes on slower emulators, activating the app requires more time then provided by default, this change solves it.

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 22, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@Dor-bl
Copy link
Collaborator

Dor-bl commented Dec 22, 2022

@agentran Thank you for the PR!
A couple of notes:

  • Please sign the CLA. It is usually a one time thing, and is required for the PR to be merged.
  • Rename the PR title to follow the conventional commit format

@agentran agentran changed the title added the ability to activate the app with timeout feat: added the ability to activate the app with timeout Dec 22, 2022
@Dor-bl
Copy link
Collaborator

Dor-bl commented Dec 30, 2022

@agentran, I see you still haven't signed the CLA. Please do, if you would like to complete this PR.

@agentran
Copy link
Contributor Author

agentran commented Jan 5, 2023

@agentran, I see you still haven't signed the CLA. Please do, if you would like to complete this PR.

Singed 👍

@Dor-bl
Copy link
Collaborator

Dor-bl commented Jan 5, 2023

@agentran thanks, just a little note.
Your PR is for the master branch which is the stable version. we are currently no longer maintaining that version, but rather focus on the beta releases. So you might want to add it there as well.
Thanks

@laolubenson laolubenson merged commit ad0296d into appium:master Jan 6, 2023
@laolubenson
Copy link
Collaborator

@Dor-bl Just clocked your last comment. Will raise a ticket to add to v5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants