Skip to content

Conversation

@cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Apr 25, 2024

What changes were proposed in this pull request?

The pr aims to upgrade Arrow from 15.0.2 to 16.0.0.

Why are the changes needed?

https://arrow.apache.org/release/16.0.0.html

SPARK-46718 and SPARK-47531 upgraded the arrow version from 14 to 15, and 15 introduced the eclipse-collections dependency.

apache/arrow#40896

Does this PR introduce any user-facing change?

No

How was this patch tested?

GA

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the BUILD label Apr 25, 2024
@cxzl25 cxzl25 changed the title [SPARK-47531][BUILD] Upgrade Arrow to 16.0.0 [SPARK-47981][BUILD] Upgrade Arrow to 16.0.0 Apr 25, 2024
yaooqinn
yaooqinn previously approved these changes Apr 25, 2024
Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yaooqinn
Copy link
Member

BTW

eclipse-collections-api/11.1.0//eclipse-collections-api-11.1.0.jar
eclipse-collections/11.1.0//eclipse-collections-11.1.0.jar

Can't these artifacts be removed?

@yaooqinn yaooqinn dismissed their stale review April 25, 2024 05:30

Still have one concern

breeze_2.13/2.1.0//breeze_2.13-2.1.0.jar
bundle/2.24.6//bundle-2.24.6.jar
cats-kernel_2.13/2.8.0//cats-kernel_2.13-2.8.0.jar
checker-qual/3.42.0//checker-qual-3.42.0.jar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was checker-qual added?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derbyshared/10.16.1.1//derbyshared-10.16.1.1.jar
derbytools/10.16.1.1//derbytools-10.16.1.1.jar
dropwizard-metrics-hadoop-metrics2-reporter/0.1.2//dropwizard-metrics-hadoop-metrics2-reporter-0.1.2.jar
eclipse-collections-api/11.1.0//eclipse-collections-api-11.1.0.jar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these two dependencies removed in the new version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @cxzl25 and all.

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaooqinn yaooqinn closed this in 7090bc1 Apr 25, 2024
@yaooqinn
Copy link
Member

Merged to master. thank you @cxzl25 @dongjoon-hyun @LuciferYang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants