GH-40896: [Java] Remove runtime dependencies on Eclipse, logback #40904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Java
awaiting committer review
Member
Author
|
@github-actions crossbow submit java |
|
Revision: 7a5ee2543fcd850374a313afb770b8f29daac1a2 Submitted crossbow builds: ursacomputing/crossbow @ actions-d2d2983571
|
Member
Author
danepitkin
approved these changes
Mar 30, 2024
Member
danepitkin
left a comment
danepitkin
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the quick fix!
Member
|
CI error looks unrelated. |
Member
Author
|
Oops, I think I need to update either LICENSE.txt or NOTICE to reflect the vendored code too. One sec... |
Member
Author
|
There is still some time for feature freeze so I'll leave this for a committer to look at. I won't be able to make updates in the next couple days but should be back online by 4/2. |
Member
|
@github-actions crossbow submit java |
|
Revision: 1070ea5 Submitted crossbow builds: ursacomputing/crossbow @ actions-f3f687f53c
|
kou
changed the title
jbonofre
reviewed
Apr 2, 2024
| SOFTWARE. | ||
|
|
||
| -------------------------------------------------------------------------------- | ||
| java/vector/src/main/java/org/apache/arrow/vector/util/IntObjectHashMap.java |
Member
There was a problem hiding this comment.
Maybe worth to mention in NOTICE file too.
Member
There was a problem hiding this comment.
If Netty doesn't have NOTICE contents for this file, we don't need to change our NOTICE file.
See also: https://infra.apache.org/licensing-howto.html#alv2-dep
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit aaacefa. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Apr 2, 2024
apache#40904) Remove runtime dependencies on [Category B](https://apache.org/legal/resolved.html#category-b) dependencies. - logback: move to test-only - eclipse: remove dependency, vendor the Netty implementation we originally used I wanted to remove javax.annotation.Generated but gRPC doesn't yet let us do that (grpc/grpc-java#9179). That's ~okay though since effectively that's a build only dependency. No. **This PR contains a "Critical Fix".** License issues do not cause runtime issues but are important as an Apache project. * GitHub Issue: apache#40896 Authored-by: David Li <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
github-actions
bot
added
awaiting changes
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Apr 4, 2024
apache#40904) Remove runtime dependencies on [Category B](https://apache.org/legal/resolved.html#category-b) dependencies. - logback: move to test-only - eclipse: remove dependency, vendor the Netty implementation we originally used I wanted to remove javax.annotation.Generated but gRPC doesn't yet let us do that (grpc/grpc-java#9179). That's ~okay though since effectively that's a build only dependency. No. **This PR contains a "Critical Fix".** License issues do not cause runtime issues but are important as an Apache project. * GitHub Issue: apache#40896 Authored-by: David Li <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
apache#40904) ### Rationale for this change Remove runtime dependencies on [Category B](https://apache.org/legal/resolved.html#category-b) dependencies. ### What changes are included in this PR? - logback: move to test-only - eclipse: remove dependency, vendor the Netty implementation we originally used I wanted to remove javax.annotation.Generated but gRPC doesn't yet let us do that (grpc/grpc-java#9179). That's ~okay though since effectively that's a build only dependency. ### Are these changes tested? apache#40901 ### Are there any user-facing changes? No. **This PR contains a "Critical Fix".** License issues do not cause runtime issues but are important as an Apache project. * GitHub Issue: apache#40896 Authored-by: David Li <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Sep 6, 2024
apache#40904) Remove runtime dependencies on [Category B](https://apache.org/legal/resolved.html#category-b) dependencies. - logback: move to test-only - eclipse: remove dependency, vendor the Netty implementation we originally used I wanted to remove javax.annotation.Generated but gRPC doesn't yet let us do that (grpc/grpc-java#9179). That's ~okay though since effectively that's a build only dependency. No. **This PR contains a "Critical Fix".** License issues do not cause runtime issues but are important as an Apache project. * GitHub Issue: apache#40896 Authored-by: David Li <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
apache#40904) ### Rationale for this change Remove runtime dependencies on [Category B](https://apache.org/legal/resolved.html#category-b) dependencies. ### What changes are included in this PR? - logback: move to test-only - eclipse: remove dependency, vendor the Netty implementation we originally used I wanted to remove javax.annotation.Generated but gRPC doesn't yet let us do that (grpc/grpc-java#9179). That's ~okay though since effectively that's a build only dependency. ### Are these changes tested? apache#40901 ### Are there any user-facing changes? No. **This PR contains a "Critical Fix".** License issues do not cause runtime issues but are important as an Apache project. * GitHub Issue: apache#40896 Authored-by: David Li <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Remove runtime dependencies on Category B dependencies.
What changes are included in this PR?
I wanted to remove javax.annotation.Generated but gRPC doesn't yet let us do that (grpc/grpc-java#9179). That's ~okay though since effectively that's a build only dependency.
Are these changes tested?
#40901
Are there any user-facing changes?
No.
This PR contains a "Critical Fix". License issues do not cause runtime issues but are important as an Apache project.