[fix][client] Fix DLQ producer name conflicts when multiples consumers send messages to DLQ #21890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s send messages to DLQ
RobertIndie
added
type/bug
1 task
Technoboy-
approved these changes
Jan 15, 2024
codelipenghui
approved these changes
Jan 15, 2024
RobertIndie
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Jan 15, 2024
…essages to DLQ (#1156) ### Motivation To keep consistent with the Java client. Releted PR: apache/pulsar#21890 ### Modifications Set DLQ producerName `fmt.Sprintf("%s-%s-%s-DLQ", r.topicName, r.subscriptionName, r.consumerName)`
RobertIndie
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Jan 15, 2024
…essages to DLQ (#1156) ### Motivation To keep consistent with the Java client. Releted PR: apache/pulsar#21890 ### Modifications Set DLQ producerName `fmt.Sprintf("%s-%s-%s-DLQ", r.topicName, r.subscriptionName, r.consumerName)` (cherry picked from commit 4e13822)
Technoboy-
pushed a commit
that referenced
this pull request
Jan 15, 2024
…s send messages to DLQ (#21890)
4 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21888
Motivation
The root cause of #21888 is that a regression bug is introduced in #21589. The producer name will be conflicted when multiple consumers in the same topic and subscription send messages to DLQ concurrently.
Modifications
{topic}-{subName}-{consumerName}-DLQas the deadLetterProducer name. For instance, it could bemy-topic-partition-0-mySub-myConsumer-DLQVerifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: