[improve] [client] Add producerName for deadLetterProducer #21589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
4 tasks
RobertIndie
approved these changes
Nov 17, 2023
15 tasks
Technoboy-
added
the
release/important-notice
Technoboy-
approved these changes
Nov 20, 2023
This was referenced Nov 22, 2023
RobertIndie
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Nov 24, 2023
### Motivation To keep consistent with the Java client. Releted PR: apache/pulsar#21589 *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* ### Modifications Set DLQ producerName `%s-%s-DLQ`
RobertIndie
added a commit
to apache/pulsar-site
that referenced
this pull request
Nov 27, 2023
This PR adds doc for apache/pulsar#21589 Co-authored-by: Zike Yang <[email protected]> --------- Co-authored-by: Zike Yang <[email protected]>
This was referenced Jan 12, 2024
15 tasks
1 task
2 tasks
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21441
Related PR: #21507
Motivation
Add producerName for dead letter producer, easier to locate problems.
Modifications
When creating a
deadLetterProducer, specify theproducerNameto replace the randomly generated name.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: crossoverJie#16