-
Notifications
You must be signed in to change notification settings - Fork 363
Add single partition router #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
ae50c8b
9ee14aa
125c578
88e1e53
fed3c1f
cc804b5
e185d9c
9cc6824
c432172
2d538f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
package pulsar | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func BenchmarkSinglePartitionRouter(b *testing.B) { | ||
shibd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
numPartitions := topicMetaData{300} | ||
router := NewSinglePartitionRouter() | ||
var expect *int | ||
for i := 0; i < b.N; i++ { | ||
p := router(&ProducerMessage{ | ||
Payload: []byte("message 2"), | ||
}, numPartitions) | ||
if expect == nil { | ||
expect = &p | ||
} | ||
assert.Equal(b, *expect, p) | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
package pulsar | ||
|
||
import "sync" | ||
|
||
var ( | ||
singlePartition *int | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DO NOT use the global variable. Please move these variables to line 28. |
||
once sync.Once | ||
) | ||
|
||
func NewSinglePartitionRouter() func(*ProducerMessage, TopicMetadata) int { | ||
return func(message *ProducerMessage, metadata TopicMetadata) int { | ||
nodece marked this conversation as resolved.
Show resolved
Hide resolved
|
||
numPartitions := metadata.NumPartitions() | ||
if len(message.OrderingKey) != 0 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I notice that Java only checks the |
||
// When an OrderingKey is specified, use the hash of that key | ||
return int(getHashingFunction(JavaStringHash)(message.OrderingKey) % numPartitions) | ||
} | ||
|
||
if len(message.Key) != 0 { | ||
// When a key is specified, use the hash of that key | ||
return int(getHashingFunction(JavaStringHash)(message.Key) % numPartitions) | ||
} | ||
once.Do(func() { | ||
if singlePartition == nil { | ||
shibd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
partition := r.R.Intn(int(numPartitions)) | ||
singlePartition = &partition | ||
} | ||
}) | ||
|
||
return *singlePartition | ||
|
||
} | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
package pulsar | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
type topicMetaData struct { | ||
partition uint32 | ||
} | ||
|
||
func (t topicMetaData) NumPartitions() uint32 { | ||
return t.partition | ||
} | ||
|
||
func TestNewSinglePartitionRouter(t *testing.T) { | ||
numPartitions := topicMetaData{2} | ||
router := NewSinglePartitionRouter() | ||
p := router(&ProducerMessage{ | ||
Payload: []byte("message 2"), | ||
}, numPartitions) | ||
assert.GreaterOrEqual(t, p, 0) | ||
|
||
p2 := router(&ProducerMessage{ | ||
Payload: []byte("message 2"), | ||
}, numPartitions) | ||
assert.Equal(t, p, p2) | ||
} | ||
|
||
func TestNewSinglePartitionRouterWithKey(t *testing.T) { | ||
router := NewSinglePartitionRouter() | ||
numPartitions := topicMetaData{3} | ||
p := router(&ProducerMessage{ | ||
Payload: []byte("message 2"), | ||
Key: "my-key", | ||
}, numPartitions) | ||
assert.Equal(t, 1, p) | ||
|
||
p2 := router(&ProducerMessage{ | ||
Key: "my-key", | ||
Payload: []byte("message 2"), | ||
}, numPartitions) | ||
assert.Equal(t, p, p2) | ||
} | ||
func TestNewSinglePartitionRouterWithOrderingKey(t *testing.T) { | ||
router := NewSinglePartitionRouter() | ||
numPartitions := topicMetaData{3} | ||
p := router(&ProducerMessage{ | ||
Payload: []byte("message 2"), | ||
OrderingKey: "my-key", | ||
}, numPartitions) | ||
assert.Equal(t, 1, p) | ||
|
||
p2 := router(&ProducerMessage{ | ||
OrderingKey: "my-key", | ||
Payload: []byte("message 2"), | ||
}, numPartitions) | ||
assert.Equal(t, p, p2) | ||
} |
Uh oh!
There was an error while loading. Please reload this page.