-
Notifications
You must be signed in to change notification settings - Fork 363
Add single partition router #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shibd
merged 10 commits into
apache:master
from
crossoverJie:add-single-partition-router
Jun 28, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ae50c8b
add single-partition-router
crossoverJie 9ee14aa
fix license
crossoverJie 125c578
fix ci
crossoverJie 88e1e53
Merge branch 'master' into add-single-partition-router
crossoverJie fed3c1f
Modify as sync.Once
crossoverJie cc804b5
Merge branch 'master' into add-single-partition-router
crossoverJie e185d9c
Update pulsar/producer_test.go
crossoverJie 9cc6824
Modify with CR
crossoverJie c432172
Verify message was published on single partition
crossoverJie 2d538f2
Merge branch 'master' into add-single-partition-router
crossoverJie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
package pulsar | ||
|
||
import "sync" | ||
|
||
func NewSinglePartitionRouter() func(*ProducerMessage, TopicMetadata) int { | ||
var ( | ||
singlePartition *int | ||
once sync.Once | ||
) | ||
return func(message *ProducerMessage, metadata TopicMetadata) int { | ||
nodece marked this conversation as resolved.
Show resolved
Hide resolved
|
||
numPartitions := metadata.NumPartitions() | ||
if len(message.Key) != 0 { | ||
// When a key is specified, use the hash of that key | ||
return int(getHashingFunction(JavaStringHash)(message.Key) % numPartitions) | ||
} | ||
once.Do(func() { | ||
partition := r.R.Intn(int(numPartitions)) | ||
singlePartition = &partition | ||
}) | ||
|
||
return *singlePartition | ||
|
||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
package pulsar | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
type topicMetaData struct { | ||
partition uint32 | ||
} | ||
|
||
func (t topicMetaData) NumPartitions() uint32 { | ||
return t.partition | ||
} | ||
|
||
func TestNewSinglePartitionRouter(t *testing.T) { | ||
numPartitions := topicMetaData{2} | ||
router := NewSinglePartitionRouter() | ||
p := router(&ProducerMessage{ | ||
Payload: []byte("message 2"), | ||
}, numPartitions) | ||
assert.GreaterOrEqual(t, p, 0) | ||
|
||
p2 := router(&ProducerMessage{ | ||
Payload: []byte("message 2"), | ||
}, numPartitions) | ||
assert.Equal(t, p, p2) | ||
} | ||
|
||
func TestNewSinglePartitionRouterWithKey(t *testing.T) { | ||
router := NewSinglePartitionRouter() | ||
numPartitions := topicMetaData{3} | ||
p := router(&ProducerMessage{ | ||
Payload: []byte("message 2"), | ||
Key: "my-key", | ||
}, numPartitions) | ||
assert.Equal(t, 1, p) | ||
|
||
p2 := router(&ProducerMessage{ | ||
Key: "my-key", | ||
Payload: []byte("message 2"), | ||
}, numPartitions) | ||
assert.Equal(t, p, p2) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.