Skip to content

Don't ignore SVG files #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Don't ignore SVG files #2435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61b229d
SVG is a data file, not autogenerated
elharo Jun 5, 2025
f4a7d87
vscode
elharo Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,22 @@
.classpath
.settings/
.svn/

Copy link
Contributor

@Pankraz76 Pankraz76 Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider block having natural order instead of having custom config.

Copy link
Contributor Author

@elharo elharo Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stet

# Intellij
*.ipr
*.iml
.idea
Copy link
Contributor

@Pankraz76 Pankraz76 Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.idea
.idea/

works as well, at least on my system.

Copy link
Contributor Author

@elharo elharo Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stet

!.idea/icon.png
.DS_Store
/bootstrap
/dependencies.xml
.java-version
.checkstyle
.factorypath
.vscode/
repo/
/*.svg

# VSCode
.vscode/
Copy link
Contributor

@Pankraz76 Pankraz76 Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.vscode/
.vscode

its working for idea as well without.

might consider natural order over all applying convention instead of configure some random blocks manually.

Copy link
Contributor Author

@elharo elharo Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stet


# Mac
.DS_Store