Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Jun 5, 2025

SVG is a data file, not autogenerated

@elharo elharo requested a review from hboutemy June 5, 2025 10:28
@gnodet
Copy link
Contributor

gnodet commented Jun 5, 2025

SVG is a data file, not autogenerated

Which SVG ?

@elharo elharo marked this pull request as ready for review June 5, 2025 14:36
@elharo
Copy link
Contributor Author

elharo commented Jun 5, 2025

Don't know, but it's not an IDE or file system artifact.

@Pankraz76
Copy link
Contributor

Which SVG ?

seems like having more obsoletes or might be intended. My wc clean with way less ignored then actually configured:

/*.svg

# VSCode
.vscode/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.vscode/
.vscode

its working for idea as well without.

might consider natural order over all applying convention instead of configure some random blocks manually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stet

# Intellij
*.ipr
*.iml
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.idea
.idea/

works as well, at least on my system.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stet

.classpath
.settings/
.svn/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider block having natural order instead of having custom config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stet

Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't care that much about the order. Let's focus on removing the clear mistake — excluding .svg files — rather than bike shedding over the rest of the file.

@elharo elharo merged commit 5676fb8 into master Jun 10, 2025
25 checks passed
@elharo elharo deleted the svg branch June 10, 2025 14:03
@github-actions github-actions bot added this to the 4.0.0-rc-4 milestone Jun 10, 2025
@Pankraz76
Copy link
Contributor

Pankraz76 commented Jun 11, 2025

don't care

yes i can tell, all around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants