-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Don't ignore SVG files #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't ignore SVG files #2435
Conversation
Which SVG ? |
|
Don't know, but it's not an IDE or file system artifact. |
seems like having more obsoletes or might be intended. My wc clean with way less ignored then actually configured: |
| /*.svg | ||
|
|
||
| # VSCode | ||
| .vscode/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .vscode/ | |
| .vscode |
its working for idea as well without.
might consider natural order over all applying convention instead of configure some random blocks manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stet
| # Intellij | ||
| *.ipr | ||
| *.iml | ||
| .idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .idea | |
| .idea/ |
works as well, at least on my system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stet
| .classpath | ||
| .settings/ | ||
| .svn/ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider block having natural order instead of having custom config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't care that much about the order. Let's focus on removing the clear mistake — excluding .svg files — rather than bike shedding over the rest of the file.
yes i can tell, all around. |
SVG is a data file, not autogenerated