Skip to content

abstract implicit used API MavenInvoker#customizeSettingsRequest #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

abstract implicit used API MavenInvoker#customizeSettingsRequest #2406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,11 +716,6 @@ protected Runnable settings(C context, boolean emitSettingsWarnings, SettingsBui
};
}

protected void customizeSettingsRequest(C context, SettingsBuilderRequest settingsBuilderRequest)
throws Exception {}

protected void customizeSettingsResult(C context, SettingsBuilderResult settingsBuilderResult) throws Exception {}

protected boolean mayDisableInteractiveMode(C context, boolean proposedInteractive) {
if (!context.invokerRequest.options().forceInteractive().orElse(false)) {
if (context.invokerRequest.options().nonInteractive().orElse(false)) {
Expand Down Expand Up @@ -936,4 +931,10 @@ protected int calculateDegreeOfConcurrency(String threadConfiguration) {
}

protected abstract int execute(C context) throws Exception;

protected abstract void customizeSettingsRequest(C context, SettingsBuilderRequest settingsBuilderRequest)
throws Exception;

protected abstract void customizeSettingsResult(C context, SettingsBuilderResult settingsBuilderResult)
throws Exception;
}
10 changes: 10 additions & 0 deletions impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvn/MavenInvoker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
import org.apache.maven.api.cli.mvn.MavenOptions;
import org.apache.maven.api.services.BuilderProblem;
import org.apache.maven.api.services.Lookup;
import org.apache.maven.api.services.SettingsBuilderRequest;
import org.apache.maven.api.services.SettingsBuilderResult;
import org.apache.maven.api.services.Sources;
import org.apache.maven.api.services.ToolchainsBuilder;
import org.apache.maven.api.services.ToolchainsBuilderRequest;
Expand Down Expand Up @@ -92,6 +94,14 @@ protected MavenContext createContext(InvokerRequest invokerRequest) {
return new MavenContext(invokerRequest);
}

@Override
protected void customizeSettingsRequest(MavenContext context, SettingsBuilderRequest settingsBuilderRequest)
throws Exception {}

@Override
protected void customizeSettingsResult(MavenContext context, SettingsBuilderResult settingsBuilderResult)
throws Exception {}

@Override
protected int execute(MavenContext context) throws Exception {
MavenExecutionRequest request = prepareMavenExecutionRequest();
Expand Down
10 changes: 10 additions & 0 deletions impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnenc/EncryptInvoker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
import org.apache.maven.api.cli.InvokerRequest;
import org.apache.maven.api.cli.mvnenc.EncryptOptions;
import org.apache.maven.api.services.Lookup;
import org.apache.maven.api.services.SettingsBuilderRequest;
import org.apache.maven.api.services.SettingsBuilderResult;
import org.apache.maven.cling.invoker.LookupContext;
import org.apache.maven.cling.invoker.LookupInvoker;
import org.apache.maven.cling.utils.CLIReportingUtils;
Expand Down Expand Up @@ -110,6 +112,14 @@ protected int execute(EncryptContext context) throws Exception {
}
}

@Override
protected void customizeSettingsRequest(EncryptContext context, SettingsBuilderRequest settingsBuilderRequest)
throws Exception {}

@Override
protected void customizeSettingsResult(EncryptContext context, SettingsBuilderResult settingsBuilderResult)
throws Exception {}

protected int badGoalsErrorMessage(String message, EncryptContext context) {
context.logger.error(message);
context.logger.error("Supported goals are: " + String.join(", ", context.goals.keySet()));
Expand Down
10 changes: 10 additions & 0 deletions impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/ShellInvoker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

import org.apache.maven.api.cli.InvokerRequest;
import org.apache.maven.api.services.Lookup;
import org.apache.maven.api.services.SettingsBuilderRequest;
import org.apache.maven.api.services.SettingsBuilderResult;
import org.apache.maven.cling.invoker.LookupContext;
import org.apache.maven.cling.invoker.LookupInvoker;
import org.apache.maven.cling.utils.CLIReportingUtils;
Expand Down Expand Up @@ -197,4 +199,12 @@ protected void commandStyle(LineReader reader, AttributedStringBuilder sb, boole
}
}
}

@Override
protected void customizeSettingsRequest(LookupContext context, SettingsBuilderRequest settingsBuilderRequest)
throws Exception {}

@Override
protected void customizeSettingsResult(LookupContext context, SettingsBuilderResult settingsBuilderResult)
throws Exception {}
}