abstract implicit used API MavenInvoker#customizeSettingsRequest

[Pankraz76]

depends on:

• Fix 'string builder buffer' can be replaced with 'string'  #2415
• try can use automatic resource management 1/2 #2401
• chore: singularize AbstractMojo#createFile(File) #2395

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MNG-XXX] SUMMARY,
  where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
• Also format the first line of the commit message like [MNG-XXX] SUMMARY.
  Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[gnodet]

I don't see any benefits in these changes, quite the opposite.

[Pankraz76]

yes, the now explicitly methods are kind of overhead, as empty like before, would be nice to have them in some kind of default impl.

Whats the matter? Its just the same method and signature, right? Empty methods will behave the same, assuming your concern is about architectural design?

To me this change only shows the real intent of this method.

Before it was a secret to override this methods, even tho its actually part of API, now as they are abstract, what they seem to be in real world, its clear and part of the contract.

[gnodet]

yes, the now explicitly methods are kind of overhead, as empty like before, would be nice to have them in some kind of default impl.

Whats the matter? Its just the same method and signature, right? Empty methods will behave the same, assuming your concern is about architectural design?

To me this change only shows the real intent of this method.

Before it was a secret to override this methods, even tho its actually part of API, now as they are abstract, what they seem to be in real world, its clear and part of the contract.

All protected methods can be overridden, that's no secret. It's a way to customize the request/result. As we see, it's usually not needed, so not sure why we'd have to force derived classes to provide two empty methods.
I think the burden outweighs the benefits here.

[Pankraz76]

I think the burden outweighs the benefits here.

agree.

having empty methods and or unused params, still remains smell.