MINOR: Remove fetchQuotaMetrics and copyQuotaMetrics on close #20394
+37
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
kamalcph
approved these changes
Aug 22, 2025
kamalcph
reviewed
Aug 22, 2025
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java
Outdated
Show resolved
Hide resolved
kamalcph
changed the title
chia7712
reviewed
Aug 23, 2025
| @@ -314,6 +314,8 @@ private void removeMetrics() { | |||
| metricsGroup.removeMetric(REMOTE_LOG_MANAGER_TASKS_AVG_IDLE_PERCENT_METRIC); | |||
| metricsGroup.removeMetric(REMOTE_LOG_READER_FETCH_RATE_AND_TIME_METRIC); | |||
| remoteStorageReaderThreadPool.removeMetrics(); | |||
| Utils.closeQuietly(fetchQuotaMetrics, "fetchQuotaMetrics"); | |||
There was a problem hiding this comment.
@jim0987795064 Could you please add unit test for it? RemoteLogManagerTest would be a good place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from: #20342 (comment)
Reviewers: Kamal Chandraprakash [email protected]