KAFKA-19597: Stop the RSM after closing the remote-log reader threads to handle requests gracefully #20342
Conversation
… to handle requests gracefully During shutdown, when the RSM closes first, then the ongoing requests might throw an error. To handle the ongoing requests gracefully, closing the RSM after closing the remote-log reader thread pools.
github-actions
bot
added
triage
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java
Show resolved
Hide resolved
| leaderCopyRLMTasks.clear(); | ||
| leaderExpirationRLMTasks.clear(); | ||
| followerRLMTasks.clear(); | ||
|
|
||
| Utils.closeQuietly(indexCache, "RemoteIndexCache"); |
There was a problem hiding this comment.
Could you please add comments explaining the new close order? Otherwise, it might be unintentionally changed in the future
There was a problem hiding this comment.
Followed caller -> callee pattern. RemoteIndexCache invokes remoteStorageManagerPlugin to fetch the indexes so changed the shutdown order.
There was a problem hiding this comment.
Followed caller -> callee pattern. RemoteIndexCache invokes remoteStorageManagerPlugin to fetch the indexes so changed the shutdown order.
yes, that is good pattern. BTW, it looks like fetchQuotaMetrics and copyQuotaMetrics are excluded by the removeMetrics. Is that expected?
There was a problem hiding this comment.
seems to be a miss to me.
There was a problem hiding this comment.
thanks for confirmation. We will file a minor PR for it.
- Changes: Remove fetchQuotaMetrics and copyQuotaMetrics in RemoteLogManager on close from: #20342 (comment) Reviewers: Kamal Chandraprakash <[email protected]>
During shutdown, when the RSM closes first, then the ongoing requests
might throw an error. To handle the ongoing requests gracefully, closing
the RSM after closing the remote-log reader thread pools.
Reviewers: Satish Duggana [email protected]