Skip to content

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Sep 26, 2025

Ⅰ. Describe what this PR did

We need to wait for PR #7644 to be merged

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.42%. Comparing base (0605fa8) to head (b1d00b8).
⚠️ Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7663      +/-   ##
============================================
+ Coverage     61.40%   61.42%   +0.01%     
  Complexity      666      666              
============================================
  Files          1314     1314              
  Lines         49853    49853              
  Branches       5874     5876       +2     
============================================
+ Hits          30612    30621       +9     
+ Misses        16455    16448       -7     
+ Partials       2786     2784       -2     

see 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slievrly
Copy link
Member

com.diffplug.spotless:spotless-maven-plugin:2.44.3 is not compatible with java25.

@funky-eyes funky-eyes requested review from Copilot, slievrly, wangliang181230 and xingfudeshi and removed request for xingfudeshi October 5, 2025 16:37
@funky-eyes funky-eyes added this to the 2.6.0 milestone Oct 5, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Java 25 support to the project's CI configuration and updates the Kotlin Maven plugin version to support Java 25 compatibility.

  • Added Java 25 to CI test matrices across all workflow files
  • Updated Kotlin Maven plugin version from 1.9.21 to 2.2.20 for Java 25 compatibility

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
build/pom.xml Updated Kotlin Maven plugin version to support Java 25
.github/workflows/test.yml Added Java 25 to test matrix for cross-platform testing
.github/workflows/test-ubuntu.yml Added Java 25 to Ubuntu-specific test matrices
.github/workflows/publish-docker.yml Added Java 25 to Docker publishing workflow
.github/workflows/build.yml Added Java 25 to build workflow matrix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@funky-eyes funky-eyes added the type: feature Category issues or prs related to feature request. label Oct 5, 2025
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 77331be into apache:2.x Oct 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Category issues or prs related to feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants