bugfix: mvn spotless:apply failed #7644

jongmin-chung · 2025-09-18T07:32:23Z

I have read the CONTRIBUTING.md guidelines.
I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes: #7640

Ⅲ. Why don't you add test cases (unit test/integration test)?

Just Maven Spoltess applied

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

jongmin-chung · 2025-09-18T08:37:48Z

Hi. @xingfudeshi

Thank you for changing the Chinese phrase.

xingfudeshi · 2025-09-18T08:43:33Z

Hi. @xingfudeshi

Thank you for changing the Chinese phrase.

No worries.

codecov · 2025-09-18T08:58:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.25%. Comparing base (b6af418) to head (92ff4bb).
⚠️ Report is 1 commits behind head on 2.x.

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #7644      +/-   ##
============================================
- Coverage     61.29%   61.25%   -0.04%     
  Complexity      666      666              
============================================
  Files          1314     1314              
  Lines         49853    49853              
  Branches       5874     5874              
============================================
- Hits          30556    30538      -18     
- Misses        16516    16531      +15     
- Partials       2781     2784       +3

Files with missing lines	Coverage Δ
...org/apache/seata/tm/api/TransactionalTemplate.java	`57.45% <ø> (ø)`

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jongmin-chung · 2025-09-18T10:06:25Z

tm/src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java

            case TimeoutRollbacked:
            case Rollbacked:
-                // rollback transactions but do not exist are usually considered completed
+            // rollback transactions but do not exist are usually considered completed


In Java 11, this comment should be indented, but not indented in Java17, Java25, which is a problem.

In Java 11, this comment should be indented, but not indented in Java17, Java25, which is a problem.

Yes — with your current changes, everything for Java11 and above should now follow the same coding style, right?

Java 11 (Has Error ❌)

$ sdk use java 11.0.27-librca $ ./mvnw spotless:check [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-tm: The following files had format violations: [ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java [ERROR] @@ -290,7 +290,7 @@ [ERROR] ················break; [ERROR] ············case·TimeoutRollbacked: [ERROR] ············case·Rollbacked: [ERROR] -············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] +················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] ············case·Finished: [ERROR] ················code·=·TransactionalExecutor.Code.RollbackDone; [ERROR] ················break; [ERROR] Run 'mvn spotless:apply' to fix these violations.

Java 17 and above (✅)

$ sdk use java 17.0.16-librca (java 21, java 25 OK) $ ./mvnw spotless:check [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-tm: The following files had format violations: [ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java [ERROR] @@ -290,7 +290,7 @@ [ERROR] ················break; [ERROR] ············case·TimeoutRollbacked: [ERROR] ············case·Rollbacked: [ERROR] -················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] +············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] ············case·Finished: [ERROR] ················code·=·TransactionalExecutor.Code.RollbackDone; [ERROR] ················break; [ERROR] Run 'mvn spotless:apply' to fix these violations. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <args> -rf :seata-tm

This is the situation above, so there's no problem starting with Java 17 or later.

I have a problem with Java 11. And this happens unconditionally because the position of the comment changes.

What should I do in this situation? (In CI, Java 17 is set, so there is no problem.)

Java 11 (Has Error ❌)

$ sdk use java 11.0.27-librca $ ./mvnw spotless:check [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-tm: The following files had format violations: [ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java [ERROR] @@ -290,7 +290,7 @@ [ERROR] ················break; [ERROR] ············case·TimeoutRollbacked: [ERROR] ············case·Rollbacked: [ERROR] -············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] +················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] ············case·Finished: [ERROR] ················code·=·TransactionalExecutor.Code.RollbackDone; [ERROR] ················break; [ERROR] Run 'mvn spotless:apply' to fix these violations.

Java 17 and above (✅)

$ sdk use java 17.0.16-librca (java 21, java 25 OK) $ ./mvnw spotless:check [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-tm: The following files had format violations: [ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java [ERROR] @@ -290,7 +290,7 @@ [ERROR] ················break; [ERROR] ············case·TimeoutRollbacked: [ERROR] ············case·Rollbacked: [ERROR] -················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] +············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] ············case·Finished: [ERROR] ················code·=·TransactionalExecutor.Code.RollbackDone; [ERROR] ················break; [ERROR] Run 'mvn spotless:apply' to fix these violations. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <args> -rf :seata-tm

This is the situation above, so there's no problem starting with Java 17 or later.

I have a problem with Java 11. And this happens unconditionally because the position of the comment changes.

What should I do in this situation? (In CI, Java 17 is set, so there is no problem.)

Have you consulted the Spotless community about how to resolve this issue?

YongGoose

For now, I think it’s best to wait for a reply on this issue.

diffplug/spotless#2625

If no response comes for a long time, then we may need to proceed with running Spotless only on a specific version.

funky-eyes · 2025-09-26T02:01:43Z

According to the description in diffplug/spotless#2625, we should drop JDK 11 and make JDK 17 the minimum required to run Spotless.

see. apache#7644 (comment)

jongmin-chung · 2025-09-26T03:49:10Z

According to the description in diffplug/spotless#2625, we should drop JDK 11 and make JDK 17 the minimum required to run Spotless.

@funky-eyes
I saw your comment and worked on that commit. Please check.

funky-eyes

LGTM @YongGoose PTAL

YongGoose · 2025-09-27T09:25:23Z

pom.xml

-            <id>java11+</id>
+            <id>java17+</id>
            <activation>
-                <jdk>[11,)</jdk>


Why is this needed?

jongmin-chung and others added 4 commits September 18, 2025 18:46

bugfix: remove jdk21-spotless and add jdk11-spotless

7eeaf47

chore: apply code when spotless:apply

02aa035

chore: add changes

cf5a9db

Fix compatibility issue with JAVA 25 in spotless

e1518f1

jongmin-chung force-pushed the bugfix/spotless_apply_java25 branch from 354a075 to e1518f1 Compare September 18, 2025 09:46

jongmin-chung commented Sep 18, 2025

View reviewed changes

funky-eyes added this to the 2.6.0 milestone Sep 22, 2025

funky-eyes added the type: bug Category issues or prs related to bug. label Sep 22, 2025

funky-eyes requested a review from YongGoose September 22, 2025 05:58

jongmin-chung mentioned this pull request Sep 22, 2025

Spotless formats code differently between JDK versions (11 vs 17 and above) diffplug/spotless#2625

Closed

Merge branch '2.x' into bugfix/spotless_apply_java25

f363780

YongGoose reviewed Sep 22, 2025

View reviewed changes

Merge branch '2.x' into bugfix/spotless_apply_java25

dd00f12

funky-eyes mentioned this pull request Sep 26, 2025

feature: add Java 25 support in CI configuration files #7663

Merged

2 tasks

funky-eyes added the first-time contributor first-time contributor label Sep 26, 2025

bugfix: drop JDK 11 and make JDK 17 the minimum required to run Spotless

3b51617

see. apache#7644 (comment)

YongGoose requested review from YongGoose and funky-eyes September 26, 2025 04:29

funky-eyes approved these changes Sep 26, 2025

View reviewed changes

YoWuwuuuw approved these changes Sep 26, 2025

View reviewed changes

YongGoose reviewed Sep 27, 2025

View reviewed changes

pom.xml

Comment on lines -266 to -268

<id>java11+</id>

<id>java17+</id>

<activation>

<jdk>[11,)</jdk>

Copy link

Member

YongGoose Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Merge branch '2.x' into bugfix/spotless_apply_java25

92ff4bb

funky-eyes merged commit 0605fa8 into apache:2.x Oct 4, 2025
11 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bugfix: mvn spotless:apply failed #7644

bugfix: mvn spotless:apply failed #7644

Uh oh!

jongmin-chung commented Sep 18, 2025 •

edited

Loading

Uh oh!

jongmin-chung commented Sep 18, 2025

Uh oh!

xingfudeshi commented Sep 18, 2025

Uh oh!

codecov bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

jongmin-chung Sep 18, 2025

Uh oh!

funky-eyes Sep 22, 2025

Uh oh!

jongmin-chung Sep 22, 2025

Uh oh!

funky-eyes Sep 22, 2025

Uh oh!

YongGoose left a comment

Uh oh!

funky-eyes commented Sep 26, 2025

Uh oh!

jongmin-chung commented Sep 26, 2025

Uh oh!

funky-eyes left a comment

Uh oh!

YongGoose Sep 27, 2025

Uh oh!

Uh oh!

Uh oh!

bugfix: mvn spotless:apply failed #7644

bugfix: mvn spotless:apply failed #7644

Uh oh!

Conversation

jongmin-chung commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

jongmin-chung commented Sep 18, 2025

Uh oh!

xingfudeshi commented Sep 18, 2025

Uh oh!

codecov bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jongmin-chung Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

funky-eyes Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

jongmin-chung Sep 22, 2025

Choose a reason for hiding this comment

Java 11 (Has Error ❌)

Java 17 and above (✅)

Uh oh!

funky-eyes Sep 22, 2025

Choose a reason for hiding this comment

Java 11 (Has Error ❌)

Java 17 and above (✅)

Uh oh!

YongGoose left a comment

Choose a reason for hiding this comment

Uh oh!

funky-eyes commented Sep 26, 2025

Uh oh!

jongmin-chung commented Sep 26, 2025

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

YongGoose Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jongmin-chung commented Sep 18, 2025 •

edited

Loading

codecov bot commented Sep 18, 2025 •

edited

Loading