Skip to content

autoconfiguration virtual-thread-pool #15220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2025
Merged

autoconfiguration virtual-thread-pool #15220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1f1b33
autoconfiguration virtual-thread-pool
heliang666s Mar 8, 2025
21f135d
restart ci
heliang666s Mar 8, 2025
948d256
restart ci
heliang666s Mar 8, 2025
5530066
Check the value
heliang666s Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...java/org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ public class DubboDefaultPropertiesEnvironmentPostProcessor implements Environme
public static final String ALLOW_BEAN_DEFINITION_OVERRIDING_PROPERTY =
"spring.main.allow-bean-definition-overriding";

public static final String DUBBO_THREAD_POOL_PROPERTY = "dubbo.protocol.threadpool";

public static final String VIRTUAL_THREAD = "virtual";

public static final String SPRING_THREAD_POOL_PROPERTY = "spring.threads.virtual.enabled";

private static final String ENABLED_VALUE = "true";

@Override
public void postProcessEnvironment(ConfigurableEnvironment environment, SpringApplication application) {
MutablePropertySources propertySources = environment.getPropertySources();
Expand All @@ -73,9 +81,17 @@ private Map<String, Object> createDefaultProperties(ConfigurableEnvironment envi
Map<String, Object> defaultProperties = new HashMap<>();
setDubboApplicationNameProperty(environment, defaultProperties);
setDubboConfigMultipleProperty(defaultProperties);
setDubboVirtualThreadsProperty(environment, defaultProperties);
return defaultProperties;
}

private void setDubboVirtualThreadsProperty(Environment environment, Map<String, Object> defaultProperties) {
String virtualEnabled = environment.getProperty(SPRING_THREAD_POOL_PROPERTY);
if (ENABLED_VALUE.equals(virtualEnabled)) {
defaultProperties.put(DUBBO_THREAD_POOL_PROPERTY, VIRTUAL_THREAD);
}
}

private void setDubboApplicationNameProperty(Environment environment, Map<String, Object> defaultProperties) {
String springApplicationName = environment.getProperty(SPRING_APPLICATION_NAME_PROPERTY);
if (StringUtils.hasLength(springApplicationName)
Expand Down
10 changes: 10 additions & 0 deletions .../org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,5 +95,15 @@ void testPostProcessEnvironment() {
instance.postProcessEnvironment(environment, springApplication);
assertEquals("false", environment.getProperty("dubbo.config.multiple"));
assertEquals("false", environment.getProperty("dubbo.application.qos-enable"));

// Case 6 : Test virtual thread property when spring.threads.virtual.enabled=true
environment = new MockEnvironment();
propertySources = environment.getPropertySources();
propertySources.addLast(new MapPropertySource("defaultProperties", new HashMap<String, Object>()));
environment.setProperty("spring.threads.virtual.enabled", "true");
instance.postProcessEnvironment(environment, springApplication);
defaultPropertySource = propertySources.get("defaultProperties");
assertNotNull(defaultPropertySource);
assertEquals("virtual", defaultPropertySource.getProperty("dubbo.protocol.threadpool"));
}
}
Loading