-
Notifications
You must be signed in to change notification settings - Fork 26.5k
autoconfiguration virtual-thread-pool #15220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15220 +/- ##
============================================
- Coverage 60.78% 60.77% -0.01%
- Complexity 10890 10893 +3
============================================
Files 1885 1885
Lines 86072 86077 +5
Branches 12892 12894 +2
============================================
- Hits 52319 52317 -2
- Misses 28306 28315 +9
+ Partials 5447 5445 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As far as I know, Virtual Threads is a new feature introduced after JDK 21, and Spring Boot added support for it starting from version 3.2. Should we add this configuration in dubbo-spring-boot-3? |
but we don‘t have |
return defaultProperties; | ||
} | ||
|
||
private void setDubboVirtualThreadsProperty(Environment environment, Map<String, Object> defaultProperties) { | ||
String virtualEnabled = environment.getProperty(SPRING_THREAD_POOL_PROPERTY); | ||
if (StringUtils.hasLength(virtualEnabled)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the value here
I think it's pretty simple at the moment, consider refactoring and pulling it out later when there's more configurations, |
What is the purpose of the change?
fix #15158
Checklist