CURATOR-596: Upgrade ZooKeeper to 3.7.1 #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
force-pushed
the
CURATOR-596-upgrade-zookeeper
branch
from
a88ad38 to
e227575
Compare
tisonkun
reviewed
Jul 12, 2022
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Generally looks good. Perhaps we should add a curator-test-zk36 module for running tests with zookeeper 3.6.x to prevent regression? You may take a look at how curator-test-zk35 does now. I'm happy to review this patch :)
cc @kezhuw
`TestReadOnly` fails due to ZOOKEEPER-3863(apache/zookeeper#1380). ZOOKEEPER-3863 uses `QuorumPeerConfig.localSessionsEnabled` to toggle local sessions supports in `ReadOnlyZooKeeperServer`. This pr populates `QuorumPeerConfig.localSessionsEnabled` and `QuorumPeerConfig.localSessionsUpgradingEnabled` from system property `readonlymode.enabled` for simplicity.
kezhuw
force-pushed
the
CURATOR-596-upgrade-zookeeper
branch
from
e227575 to
b83a475
Compare
Member
Author
|
@tisonkun I have rebased this pr to master for 5.4.0-SNAPSHOT and push a fixup commit for module |
Signed-off-by: tison <[email protected]>
tisonkun
approved these changes
Jul 14, 2022
Member
|
@kezhuw Thanks for your contribution! Merging if CI gives green. |
Member
|
Merging... @kezhuw thank you very much! |
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestReadOnlyfails due to ZOOKEEPER-3863(apache/zookeeper#1380).ZOOKEEPER-3863 uses
QuorumPeerConfig.localSessionsEnabledto togglelocal sessions supports in
ReadOnlyZooKeeperServer.This pr populates
QuorumPeerConfig.localSessionsEnabledandQuorumPeerConfig.localSessionsUpgradingEnabledfrom system propertyreadonlymode.enabledfor simplicity.