CURATOR-587 zookeeper embedded - preview #379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
my IDE reformatted part of the code, I will revert |
eolivelli
force-pushed
the
impl/CURATOR-587-zookeeper-embedded
branch
from
8e5adef to
8665ed7
Compare
eolivelli
force-pushed
the
impl/CURATOR-587-zookeeper-embedded
branch
from
2beb3c1 to
2eb6483
Compare
eolivelli
commented
Jul 1, 2022
pom.xml
Outdated
|
|
||
| <!-- versions --> | ||
| <zookeeper-version>3.6.3</zookeeper-version> | ||
| <zookeeper-version>3.7.1-SNAPSHOT</zookeeper-version> |
Contributor
Author
There was a problem hiding this comment.
we have to move this to 3.7.1
in 3.7.1 we have fixed a few problems in ZK Embedded, and 3.8.0 is also better
Member
There was a problem hiding this comment.
Since @kezhuw resolves CURATOR-596 by #426 I'd cc you here if you're interested in taking over this patch also.
Contributor
Author
There was a problem hiding this comment.
I have rebased on current master
eolivelli
force-pushed
the
impl/CURATOR-587-zookeeper-embedded
branch
from
2eb6483 to
6430908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preview patch for when we will have ZK 3.7.0 and the official ZooKeeperServerEmbedded API.
At that time we won't need to hack the internals of ZK