Skip to content

[CI] Pin homebrew LLVM@9 #8499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kszucs wants to merge 2 commits into from
Closed

[CI] Pin homebrew LLVM@9 #8499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3076eb
Pin homebrew LLVM@9
kszucs Oct 21, 2020
394bc59
Restore llvm for clang@8 tools
kszucs Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/Brewfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ brew "flatbuffers"
brew "git"
brew "glog"
brew "grpc"
brew "llvm"
brew "llvm@8"
Copy link
Member

@kou kou Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need LLVM 8 for Clang Tools such as clang-tidy.

Copy link
Member Author

@kszucs kszucs Oct 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou how about separating a Brewfile required for CI and one for local development?

Copy link
Member

@kou kou Oct 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK to me.
But I'm not sure we can maintain both of them.

brew "llvm@9"
brew "lz4"
brew "minio"
brew "ninja"
Expand Down