-
Notifications
You must be signed in to change notification settings - Fork 4k
[CI] Pin homebrew LLVM@9 #8499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Pin homebrew LLVM@9 #8499
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
|
@ursabot crossbow submit -g gandiva |
|
@kszucs, @naman1996 tried to build gandiva with this change and it is failing when it tries to install llvm 10 as part of make. (see cpp/CmakeLists.txt) p.s., is there a way to trigger gandiva nightly builds using ursabot? we were able to do |
|
@github-actions crossbow submit gandiva* |
| brew "glog" | ||
| brew "grpc" | ||
| brew "llvm" | ||
| brew "llvm@8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need LLVM 8 for Clang Tools such as clang-tidy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou how about separating a Brewfile required for CI and one for local development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK to me.
But I'm not sure we can maintain both of them.
|
@github-actions crossbow submit -g gandiva |
|
Revision: a3076eb Submitted crossbow builds: ursa-labs/crossbow @ actions-659
|
|
@github-actions crossbow submit -g gandiva |
|
Revision: a3076eb Submitted crossbow builds: ursa-labs/crossbow @ actions-666
|
|
@kou we are working on it. Also, we will do the llvm11 upgrade in linux docker image for gandiva-jar-xenial later |
|
Great! FYI: We can't use LLVM 11 on Ubuntu Xenial because g++ 5 on Ubuntu Xenial is old to use LLVM 11. LLVM 11 requires C++ 14 but g++ 5's C++ 14 support is limited. |
|
I close this because #8521 is merged. |
No description provided.