Skip to content

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Oct 21, 2020

No description provided.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@pprudhvi
Copy link
Contributor

@ursabot crossbow submit -g gandiva

@pprudhvi
Copy link
Contributor

pprudhvi commented Oct 21, 2020

@kszucs, @naman1996 tried to build gandiva with this change and it is failing when it tries to install llvm 10 as part of make. (see cpp/CmakeLists.txt)

p.s., is there a way to trigger gandiva nightly builds using ursabot? we were able to do @ursabot crossbow submit earlier.

@naman1996
Copy link

@github-actions crossbow submit gandiva*

brew "glog"
brew "grpc"
brew "llvm"
brew "llvm@8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need LLVM 8 for Clang Tools such as clang-tidy.

Copy link
Member Author

@kszucs kszucs Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou how about separating a Brewfile required for CI and one for local development?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK to me.
But I'm not sure we can maintain both of them.

@kou
Copy link
Member

kou commented Oct 21, 2020

@github-actions crossbow submit -g gandiva

@github-actions
Copy link

Revision: a3076eb

Submitted crossbow builds: ursa-labs/crossbow @ actions-659

Task Status
gandiva-jar-osx TravisCI
gandiva-jar-xenial TravisCI

@pprudhvi
Copy link
Contributor

@github-actions crossbow submit -g gandiva

@github-actions
Copy link

Revision: a3076eb

Submitted crossbow builds: ursa-labs/crossbow @ actions-666

Task Status
gandiva-jar-osx TravisCI
gandiva-jar-xenial TravisCI

@pprudhvi
Copy link
Contributor

@kszucs , @kou Can we make gandiva-jar-osx build pass before merging this? If llvm10 is not available, cmake should pickup llvm9, somehow this is not happening.

@kou
Copy link
Member

kou commented Oct 24, 2020

We don't need this once #8521 is merged.

@pprudhvi BTW, could you fix the gandiva-jar-xenial failure?
It seems that this is caused by f1f4001 .

@pprudhvi
Copy link
Contributor

pprudhvi commented Oct 25, 2020

@kou we are working on it. Also, we will do the llvm11 upgrade in linux docker image for gandiva-jar-xenial later

@kou
Copy link
Member

kou commented Oct 25, 2020

Great!

FYI: We can't use LLVM 11 on Ubuntu Xenial because g++ 5 on Ubuntu Xenial is old to use LLVM 11. LLVM 11 requires C++ 14 but g++ 5's C++ 14 support is limited.
We're using LLVM 8 for the deb package for Ubuntu Xenial: https://github.com/apache/arrow/blob/master/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-xenial/Dockerfile#L32-L35

@kou
Copy link
Member

kou commented Oct 30, 2020

I close this because #8521 is merged.

@kou kou closed this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants