GH-47707: [C++][FlightRPC] Add tests for descriptor handle allocation #48053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
commented
Nov 10, 2025
github-actions
bot
added
awaiting committer review
alinaliBQ
commented
Nov 11, 2025
alinaliBQ
force-pushed
the
gh-47707-descriptor-handle
branch
from
65a1708 to
5041f73
Compare
alinaliBQ
changed the title
alinaliBQ
commented
Nov 11, 2025
Contributor
Author
|
@lidavidm this draft PR is ready for review! Please have a look |
Contributor
Author
|
Will rebase to resolve conflict |
alinaliBQ
force-pushed
the
gh-47707-descriptor-handle
branch
2 times, most recently
from
5dc4249 to
52d15cf
Compare
Add doxygen doc Co-Authored-By: alinalibq <[email protected]>
alinaliBQ
force-pushed
the
gh-47707-descriptor-handle
branch
from
52d15cf to
b6e87e2
Compare
lidavidm
approved these changes
Dec 9, 2025
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f8b23be. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add tests for
SQL_HANDLE_DESCdescriptor handle allocation, and diagnostics test. Related test updatesWhat changes are included in this PR?
SQL_HANDLE_DESCnullptrexplicitly where applicableAre these changes tested?
Tested on local MSVC Windows
Are there any user-facing changes?
N/A