GH-47715: [C++][FlightRPC] ODBC scroll fetch implementation #48041
+129
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
changed the title
|
|
alinaliBQ
force-pushed
the
gh-47715-sql-extended-scroll
branch
from
e01ec17 to
bc97bd2
Compare
alinaliBQ
changed the title
Contributor
Author
|
@lidavidm this draft PR is ready for review! Please have a look |
alinaliBQ
force-pushed
the
gh-47715-sql-extended-scroll
branch
from
bc97bd2 to
5e788c7
Compare
alinaliBQ
force-pushed
the
gh-47715-sql-extended-scroll
branch
from
5e788c7 to
2760394
Compare
lidavidm
approved these changes
Dec 8, 2025
github-actions
bot
added
awaiting merge
alinaliBQ
force-pushed
the
gh-47715-sql-extended-scroll
branch
from
2760394 to
b2919bd
Compare
Fix comments and use `ARROW_UNUSED` Co-Authored-By: alinalibq <[email protected]>
- be explicit with nullptr instead of 0
alinaliBQ
force-pushed
the
gh-47715-sql-extended-scroll
branch
from
b2919bd to
a3aa3cc
Compare
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4fc9f9e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ODBC scroll fetch implementation. This is part of advance ODBC data fetching.
What changes are included in this PR?
SQL_FETCH_NEXTis supported, which makes it has same effect as SQLFetchAre these changes tested?
Tested in local MSVC.
Are there any user-facing changes?
N/A