GH-47713: [C++][FlightRPC] ODBC Basic Data Retrieval #48034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
force-pushed
the
gh-47713-sql-fetch-get-data
branch
from
26304de to
7145d4a
Compare
alinaliBQ
changed the title
alinaliBQ
force-pushed
the
gh-47713-sql-fetch-get-data
branch
2 times, most recently
from
a0b2ecf to
a5ad706
Compare
Contributor
Author
|
@lidavidm this draft PR is ready for review! Please have a look |
alinaliBQ
force-pushed
the
gh-47713-sql-fetch-get-data
branch
from
a5ad706 to
62fd08d
Compare
lidavidm
approved these changes
Dec 4, 2025
Fix doxygen Use `\return` not `\returns` Co-Authored-By: alinalibq <[email protected]>
alinaliBQ
force-pushed
the
gh-47713-sql-fetch-get-data
branch
from
62fd08d to
eab3069
Compare
alinaliBQ
commented
Dec 4, 2025
| using TestTypes = ::testing::Types<StatementMockTest, StatementRemoteTest>; | ||
| TYPED_TEST_SUITE(StatementTest, TestTypes); | ||
|
|
||
| TYPED_TEST(StatementTest, TestSQLExecDirectSimpleQuery) { |
Contributor
Author
There was a problem hiding this comment.
Some tests are from #48032. This PR enables the data fetching part of the test as SQLGetData and SQLFetch are implemented
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Dec 5, 2025
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1f599f4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add implementation for ODBC basic data fetching and retrieval
What changes are included in this PR?
odbc_implAre these changes tested?
Tested on local MSVC.
Are there any user-facing changes?
N/A