Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Sep 19, 2025

Rationale for this change

There are several things that make this change wanted. We want to move some CI jobs from ursacomputing/crossbow to apache/arrow. Moving the Linux Packaging jobs will allow us to automate some release tasks and potentially (if we are able to make reproducible builds for linux packaging work) add automated signing to them avoiding having to require a PMC signature for the Linux packaging artifacts.

What changes are included in this PR?

  • Move check_labels and report_ci jobs to independent reusable workflows.
  • Update cpp_extra to use those.
  • Create new linux_packaging.yml workflow replicating work that was done on crossbow. Integrate that workflow with check_labels and report_ci
  • Update release binary submit and binary download to run workflow when tag is pushed and download the artifacts from the release instead of from the crossbow repository.

Are these changes tested?

Some via CI on fork and some manual testing.

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #47582 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 19, 2025
Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kou I've started working on this and I think I have a working base that could work. I wanted to discuss it with you before moving more packages to validate we are all ok with the approach.
Let me know your thoughts. I have a couple of questions to discuss too, let me know what you think on those too.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Sep 19, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Sep 19, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Sep 19, 2025
@raulcd raulcd force-pushed the GH-47582 branch 3 times, most recently from 1121d15 to 78e0ff2 Compare September 22, 2025 10:35
Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone over all the comments and I think this is ready for another review.

@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Sep 23, 2025
# to finish before downloading the artifacts.
. "${SOURCE_DIR}/utils-watch-gh-workflow.sh" "${release_tag}" "package_linux.yml"

RUN_ID=$(get_run_id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you want to use a function defined in utils-watch-gh-workflow.sh.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Sep 23, 2025
@kou
Copy link
Member

kou commented Oct 7, 2025

This is ready.

I've fixed problems found by tag test on my fork.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Oct 7, 2025
Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I am happy to merge. I can't approve though as I created the PR

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I merge this.

@kou kou merged commit e137a04 into apache:main Oct 7, 2025
60 of 61 checks passed
@kou kou removed the awaiting changes Awaiting changes label Oct 7, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 7, 2025
@raulcd raulcd deleted the GH-47582 branch October 7, 2025 09:22
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit e137a04.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

kou added a commit to kou/arrow-adbc that referenced this pull request Oct 8, 2025
kou added a commit to kou/arrow-adbc that referenced this pull request Oct 8, 2025
lidavidm pushed a commit to apache/arrow-adbc that referenced this pull request Oct 8, 2025
…ow (#3545)

apache/arrow#47600 is merged. It changed
required directory structure. We don't need to change directory
structure now.

Fixes #3510.
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Oct 15, 2025
…arrow repository (apache#47600)

### Rationale for this change

There are several things that make this change wanted. We want to move some CI jobs from `ursacomputing/crossbow` to `apache/arrow`. Moving the Linux Packaging jobs will allow us to automate some release tasks and potentially (if we are able to make reproducible builds for linux packaging work) add automated signing to them avoiding having to require a PMC signature for the Linux packaging artifacts.

### What changes are included in this PR?

- Move `check_labels` and `report_ci` jobs to independent reusable workflows.
- Update `cpp_extra` to use those.
- Create new `linux_packaging.yml` workflow replicating work that was done on crossbow. Integrate that workflow with `check_labels` and `report_ci`
- Update release binary submit and binary download to run workflow when tag is pushed and download the artifacts from the release instead of from the crossbow repository.

### Are these changes tested?

Some via CI on fork and some manual testing.

### Are there any user-facing changes?

No

* GitHub Issue: apache#47582

Lead-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
kou added a commit to groonga/groonga that referenced this pull request Oct 15, 2025
Apache Arrow changed SRPM output location from `source/SRPMS/` to
`Source/Packages/`.
- ref: apache/arrow#47600

This change breaks Yum repository compatibility for existed
distributions. This commit adds path management after `yum:build` to
maintain compatibility:

- For AlmaLinux 10 and earlier and Amazon Linux 2023: Rename SRPMs path
from `Source/Packages/` to `source/` for backward compatibility
- For AlmaLinux 11 and later: Uses the new `Source/Packages/` path
- Except for x86 architecture: Removes SRPMs

---------

Co-authored-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants