-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-47582: [CI][Packaging] Move linux-packaging tasks to apache/arrow repository #47600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kou I've started working on this and I think I have a working base that could work. I wanted to discuss it with you before moving more packages to validate we are all ok with the approach.
Let me know your thoughts. I have a couple of questions to discuss too, let me know what you think on those too.
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
1121d15 to
78e0ff2
Compare
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone over all the comments and I think this is ready for another review.
dev/release/04-binary-download.sh
Outdated
| # to finish before downloading the artifacts. | ||
| . "${SOURCE_DIR}/utils-watch-gh-workflow.sh" "${release_tag}" "package_linux.yml" | ||
|
|
||
| RUN_ID=$(get_run_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you want to use a function defined in utils-watch-gh-workflow.sh.
|
This is ready. I've fixed problems found by tag test on my fork. |
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I am happy to merge. I can't approve though as I created the PR
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I merge this.
|
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit e137a04. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ow (#3545) apache/arrow#47600 is merged. It changed required directory structure. We don't need to change directory structure now. Fixes #3510.
…arrow repository (apache#47600) ### Rationale for this change There are several things that make this change wanted. We want to move some CI jobs from `ursacomputing/crossbow` to `apache/arrow`. Moving the Linux Packaging jobs will allow us to automate some release tasks and potentially (if we are able to make reproducible builds for linux packaging work) add automated signing to them avoiding having to require a PMC signature for the Linux packaging artifacts. ### What changes are included in this PR? - Move `check_labels` and `report_ci` jobs to independent reusable workflows. - Update `cpp_extra` to use those. - Create new `linux_packaging.yml` workflow replicating work that was done on crossbow. Integrate that workflow with `check_labels` and `report_ci` - Update release binary submit and binary download to run workflow when tag is pushed and download the artifacts from the release instead of from the crossbow repository. ### Are these changes tested? Some via CI on fork and some manual testing. ### Are there any user-facing changes? No * GitHub Issue: apache#47582 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Apache Arrow changed SRPM output location from `source/SRPMS/` to `Source/Packages/`. - ref: apache/arrow#47600 This change breaks Yum repository compatibility for existed distributions. This commit adds path management after `yum:build` to maintain compatibility: - For AlmaLinux 10 and earlier and Amazon Linux 2023: Rename SRPMs path from `Source/Packages/` to `source/` for backward compatibility - For AlmaLinux 11 and later: Uses the new `Source/Packages/` path - Except for x86 architecture: Removes SRPMs --------- Co-authored-by: Sutou Kouhei <[email protected]>
Rationale for this change
There are several things that make this change wanted. We want to move some CI jobs from
ursacomputing/crossbowtoapache/arrow. Moving the Linux Packaging jobs will allow us to automate some release tasks and potentially (if we are able to make reproducible builds for linux packaging work) add automated signing to them avoiding having to require a PMC signature for the Linux packaging artifacts.What changes are included in this PR?
check_labelsandreport_cijobs to independent reusable workflows.cpp_extrato use those.linux_packaging.ymlworkflow replicating work that was done on crossbow. Integrate that workflow withcheck_labelsandreport_ciAre these changes tested?
Some via CI on fork and some manual testing.
Are there any user-facing changes?
No