Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Jun 2, 2025

Rationale for this change

We have been adding more linters to our pre-commit tool and this seems to be timing out consistently on CI now.

What changes are included in this PR?

Increase the timeout

Are these changes tested?

Yes, CI

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

⚠️ GitHub issue #46528 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Member

pitrou commented Jun 2, 2025

Instead of blindly increasing the timeout, can we please look into reducing the build time?

@raulcd
Copy link
Member Author

raulcd commented Jun 2, 2025

Instead of blindly increasing the timeout, can we please look into reducing the build time?

I agree, this is what I wanted to say with my comment on the issue here:
#46528 (comment)
Currently we are merging things with broken CI. I was suggesting whether we should increase temporarily to at least validate CI.

@raulcd
Copy link
Member Author

raulcd commented Jun 2, 2025

I am closing this. It seems we are running linters both on pre-commit and archery now. We probably should avoid double running them.

@raulcd raulcd closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting committer review Awaiting committer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants