GH-40428: [Python][CI] Fix dataset partition filter tests with pandas nightly #40429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
Author
|
@github-actions crossbow submit test-conda-python-3.10-pandas-nightly |
|
Revision: 26c53c3 Submitted crossbow builds: ursacomputing/crossbow @ actions-3bc5d6c7a3
|
jorisvandenbossche
changed the title
Member
Author
|
@github-actions crossbow submit test-conda-python-3.10-pandas-nightly |
|
Revision: 62bf9dd Submitted crossbow builds: ursacomputing/crossbow @ actions-a15ea740b7
|
jorisvandenbossche
removed
the
awaiting committer review
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 788200a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
From debugging the failure, it seems this is due to pandas changing a filter operation to sometimes preserve a RangeIndex now instead of returning an Integer64Index. And the conversion to Arrow changes based on that (RangeIndex is metadata only by default, integer index becomes a column)
Therefore making the tests more robust to ensure there is always at least one non-partition column in the DataFrame, so it doesn't depend on the index whether the result is empty or not.