ARROW-4642: [R] change f to file in read_parquet_file() #3703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you open an issue on JIRA:https://issues.apache.org/jira/browse/ARROW and prepend "ARROW-XXX: [R] " to the title? See also https://cwiki.apache.org/confluence/display/ARROW/Contributing+to+Apache+Arrow |
Member
|
@bgreenwell could You please add a simple test case for it? |
kou
changed the title
Closed
wesm
approved these changes
Feb 25, 2019
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1. We have no tests at all for R+Parquet so I presume that @romainfrancois will address that in due course
wesm
pushed a commit
that referenced
this pull request
Feb 25, 2019
Otherwise you get the following error: ``` Error in read_parquet_file(f) : object 'f' not found ``` Author: Brandon Greenwell <[email protected]> Closes #3703 from bgreenwell/patch-1 and squashes the following commits: bda541b <Brandon Greenwell> 🐛 change f to file in read_parquet_file()
wesm
changed the title
Contributor
|
Yes. |
This was referenced Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise you get the following error: