fix R parquet #3366
Closed
fix R parquet #3366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainfrancois
approved these changes
Jan 10, 2019
Contributor
romainfrancois
left a comment
romainfrancois
left a comment
There was a problem hiding this comment.
Thanks.
@wesm we can either merge this anytime, otherwise i’m soon working on another parquet pr with tests and writing
Member
|
I'll wait for unit tests, if that is okay. Since we aren't able to package R yet for CRAN (still no conclusive plan based on https://lists.apache.org/thread.html/13dda66d913c099af37e29165f45453cab8952d35380c14a038acfc4@%3Cdev.arrow.apache.org%3E) for 0.12 there is no immediate urgency |
Contributor
Author
|
@romainfrancois are you already working on a write_parquet and tests for read/write? If not I can contribute so that this is mergeable |
Member
Contributor
|
Hello, parquet is next on my agenda, but things always find a way to skip the line, e.g. holidays this week |
Member
|
I had merged the other fix, so closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @romainfrancois , this is a one line fix to
read_parquet. We accidentally left filename asf, when it should befile