-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-36886: [C++] Configure azurite in preparation for testing Azure C++ filesystem
#36988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36886: [C++] Configure azurite in preparation for testing Azure C++ filesystem
#36988
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
8c5060f to
d1102fc
Compare
azurite in preparation for testing Azure C++ filesystem
|
|
| // under the License. | ||
|
|
||
| #include "arrow/filesystem/azurefs.h" | ||
| #include <boost/process.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use
arrow/cpp/src/arrow/filesystem/gcsfs_test.cc
Lines 18 to 35 in 7cbbd3e
| #include <algorithm> // Missing include in boost/process | |
| #define BOOST_NO_CXX98_FUNCTION_BASE // ARROW-17805 | |
| // This boost/asio/io_context.hpp include is needless for no MinGW | |
| // build. | |
| // | |
| // This is for including boost/asio/detail/socket_types.hpp before any | |
| // "#include <windows.h>". boost/asio/detail/socket_types.hpp doesn't | |
| // work if windows.h is already included. boost/process.h -> | |
| // boost/process/args.hpp -> boost/process/detail/basic_cmd.hpp | |
| // includes windows.h. boost/process/args.hpp is included before | |
| // boost/process/async.h that includes | |
| // boost/asio/detail/socket_types.hpp implicitly is included. | |
| #include <boost/asio/io_context.hpp> | |
| // We need BOOST_USE_WINDOWS_H definition with MinGW when we use | |
| // boost/process.hpp. See BOOST_USE_WINDOWS_H=1 in | |
| // cpp/cmake_modules/ThirdpartyToolchain.cmake for details. | |
| #include <boost/process.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason not to
Co-authored-by: Sutou Kouhei <[email protected]>
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit f055f5e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
…Azure C++ filesystem (apache#36988) ### Rationale for this change We need to write tests for apache#18014. azurite is like a fake Azure blob storage so it can be used to write integration tests ### What changes are included in this PR? Extract the `azurite` related changes from apache#12914 to create a smaller PR that's easier to review. I have made very minimal changes compared to that PR. Currently `azurite` is configured for all the environments where `ARROW_AZURE` was enabled by apache#35701. I assume its deliberate that its not enabled yet for windows, alpine, conda, debian or fedora builds. ### Are these changes tested? Its tested by there aren't really any good tests in this PR. I used this `azurite` config in apache#36835 to make an integration test that uses the Azure C++ SDK. On its own we can't really write tests for this `azurite` setup PR. ### Are there any user-facing changes? No * Closes: apache#36886 Lead-authored-by: Thomas Newton <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
We need to write tests for #18014. azurite is like a fake Azure blob storage so it can be used to write integration tests
What changes are included in this PR?
Extract the
azuriterelated changes from #12914 to create a smaller PR that's easier to review. I have made very minimal changes compared to that PR.Currently
azuriteis configured for all the environments whereARROW_AZUREwas enabled by #35701. I assume its deliberate that its not enabled yet for windows, alpine, conda, debian or fedora builds.Are these changes tested?
Its tested by there aren't really any good tests in this PR. I used this
azuriteconfig in #36835 to make an integration test that uses the Azure C++ SDK. On its own we can't really write tests for thisazuritesetup PR.Are there any user-facing changes?
No
azuritein preparation for testing Azure C++ filesystem #36886