ARROW-15272: [Java] Add cleanup failures as suppressed in ArrowVectorIterator#create #12094
Conversation
|
|
BryanCutler
left a comment
BryanCutler
left a comment
There was a problem hiding this comment.
Looks good, just requesting to use function from Autocloseables.
| } catch (Throwable e) { | ||
| if (iterator != null) { | ||
| iterator.close(); | ||
| try { |
There was a problem hiding this comment.
You could call Autocloseables.close(iterator) which would do the same thing
|
merged to master, thanks @ahggns ! |
|
Benchmark runs are scheduled for baseline = fe953ea and contender = fa78edc. fa78edc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…Iterator#create Closes apache#12094 from ahggns/ah/arrow-15272 Authored-by: Andrew Higgins <[email protected]> Signed-off-by: Bryan Cutler <[email protected]>
3 participants
No description provided.