Skip to content

ARROW-1609: [Plasma] Xcode 9 compilation workaround #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pcmoritz wants to merge 2 commits into from
Closed

ARROW-1609: [Plasma] Xcode 9 compilation workaround #1144

pcmoritz wants to merge 2 commits into from

Conversation

@pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Sep 27, 2017

see #1139

@pcmoritz pcmoritz changed the title ARROW-1609: Plasma] Xcode 9 compilation workaround ARROW-1609: [Plasma] Xcode 9 compilation workaround Sep 27, 2017
@pcmoritz pcmoritz mentioned this pull request Sep 28, 2017
Closed
xhochy
xhochy approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@asfgit asfgit closed this in 78181d8 Sep 28, 2017
@wesm wesm deleted the plasma-xcode-9-workaround branch September 28, 2017 14:32
wesm pushed a commit to wesm/arrow that referenced this pull request Oct 3, 2017
@pcmoritz @wesm
ARROW-1609: [Plasma] Xcode 9 compilation workaround
c358154 
see apache#1139

Author: Philipp Moritz <[email protected]>

Closes apache#1144 from pcmoritz/plasma-xcode-9-workaround and squashes the following commits:

7642499 [Philipp Moritz] fix on other platforms
c5cdddd [Philipp Moritz] xcode 9 compilation workaround
@xhochy
Copy link
Member

xhochy commented Oct 27, 2017

I'm seeing this error now also pop up in the unittests of plasma on macOS.

@xhochy
Copy link
Member

xhochy commented Oct 27, 2017

@pcmoritz Do you also see these problems or is there something non-standard in my setup?

@pcmoritz
Copy link
Contributor Author

pcmoritz commented Oct 27, 2017

I was still using XCode 8 but installing version 9 now and looking into this.

@robertnishihara
Copy link
Contributor

robertnishihara commented Oct 28, 2017

I can reproduce the problem.

@robertnishihara
Copy link
Contributor

robertnishihara commented Oct 28, 2017

Should be fixed by #1261.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhochy xhochy xhochy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcmoritz @xhochy @robertnishihara