Fixed compilation errors with clang 9. #1139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
reviewed
Sep 27, 2017
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
Can you open a JIRA for this and add it to the PR title? Thanks
| typedef __darwin_mach_port_t mach_port_t; | ||
| #include <pthread.h> | ||
| mach_port_t pthread_mach_thread_np(pthread_t); | ||
| #endif /* _MACH_PORT_T */ |
Member
There was a problem hiding this comment.
Can this be put in a common header?
|
Oddly enough for me, master builds just fine with XCode9 |
Contributor
|
@hntd187 This is probably because plasma is not compiled by default, the error should be reproducible as in https://issues.apache.org/jira/browse/ARROW-1622 |
Contributor
Author
|
Alright, I'll close this one. Thank you! |
asfgit
pushed a commit
that referenced
this pull request
Sep 28, 2017
see #1139 Author: Philipp Moritz <[email protected]> Closes #1144 from pcmoritz/plasma-xcode-9-workaround and squashes the following commits: 7642499 [Philipp Moritz] fix on other platforms c5cdddd [Philipp Moritz] xcode 9 compilation workaround
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Oct 3, 2017
see apache#1139 Author: Philipp Moritz <[email protected]> Closes apache#1144 from pcmoritz/plasma-xcode-9-workaround and squashes the following commits: 7642499 [Philipp Moritz] fix on other platforms c5cdddd [Philipp Moritz] xcode 9 compilation workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for more information: ray-project/ray#1000.