Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Add --ie32 commandline option to webdriver_manager #2406

Closed
wants to merge 3 commits into from
Closed

Add --ie32 commandline option to webdriver_manager #2406

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5a434a
Add --ie32 commandline option to webdriver_manager
Aug 6, 2015
721128e
review comments
Aug 28, 2015
45215e6
review comments
Aug 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions bin/webdriver-manager
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,20 @@ var binaries = {
}
}
}
},
ie32: {
name: 'IEDriver',
isDefault: false,
prefix: 'IEDriverServer',
filename: 'IEDriverServer_' + versions.iedriver + '.zip',
cdn: 'https://selenium-release.storage.googleapis.com/',
url: function() {
var urlPrefix = this.cdn +
shortVersion(versions.iedriver) + '/IEDriverServer';
if (os.type() == 'Windows_NT') {
return urlPrefix + '_Win32_' + versions.iedriver + '.zip';
}
}
}
};

Expand All @@ -92,7 +106,9 @@ var cli = optimist.
describe('ignore_ssl', 'Ignore SSL certificates').boolean('ignore_ssl').
default('ignore_ssl', false).
describe('proxy', 'Proxy to use for the install or update command').
describe('alternate_cdn', 'Alternate CDN to the binaries');
describe('alternate_cdn', 'Alternate CDN to the binaries').
describe('ie32', 'Use 32-bit IE driver regardless of current architecture').boolean('ie32').
Copy link
Contributor

@hankduan hankduan Aug 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't do anything. The line for (bin in binaries) {... actually adds all the instructions for the binary installations.

Copy link
Contributor

@hankduan hankduan Aug 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the name of the binary to 'IEDriver-32bit', and remove the describe statement.

default('ie32', false);

for (bin in binaries) {
cli.describe(bin, 'Install or update ' + binaries[bin].name).
Expand Down Expand Up @@ -312,7 +328,7 @@ switch (argv._[0]) {
});
}
if (argv.ie) {
downloadIfNew(binaries.ie, argv.out_dir, existingFiles,
downloadIfNew(argv.ie32 ? binaries.ie32 : binaries.ie, argv.out_dir, existingFiles,
function(filename) {
var zip = new AdmZip(filename);
// Expected contents of the zip:
Expand Down