Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Conversation

@rogierschouten
Copy link

Fixes #1297

The new option allows to download the 32-bit version of the IE driver on
a 64-bit system, as the 64-bit version has been broken for over a year
now (the sendKeys() function works very slowly on it).

The new option allows to download the 32-bit version of the IE driver on
a 64-bit system, as the 64-bit version has been broken for over a year
now (the sendKeys() function works very slowly on it).
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rogierschouten
Copy link
Author

CLA has been signed in the meantime

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@rogierschouten
Copy link
Author

Commit author has been updated to match the CLA

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 6, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't do anything. The line for (bin in binaries) {... actually adds all the instructions for the binary installations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the name of the binary to 'IEDriver-32bit', and remove the describe statement.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@hankduan
Copy link
Contributor

@rogierschouten Have you tested it? I can't test it right now since I don't have a windows machine, but the code looks good. As soon as you can confirm that you tested it, and sign the CLA again, I'll pull it in.

@rogierschouten
Copy link
Author

I plan to test it at work next Monday, I can't do so now either. I'll let you know, thank you

@googlebot
Copy link

CLAs look good, thanks!

@rogierschouten
Copy link
Author

Tested & working!

@hankduan
Copy link
Contributor

hankduan commented Sep 1, 2015

Thanks! Merged: c989a7e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants