-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add --ie32 commandline option to webdriver_manager #2406
Conversation
The new option allows to download the 32-bit version of the IE driver on a 64-bit system, as the 64-bit version has been broken for over a year now (the sendKeys() function works very slowly on it).
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
CLA has been signed in the meantime |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Commit author has been updated to match the CLA |
|
CLAs look good, thanks! |
bin/webdriver-manager
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't do anything. The line for (bin in binaries) {... actually adds all the instructions for the binary installations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change the name of the binary to 'IEDriver-32bit', and remove the describe statement.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
@rogierschouten Have you tested it? I can't test it right now since I don't have a windows machine, but the code looks good. As soon as you can confirm that you tested it, and sign the CLA again, I'll pull it in. |
|
I plan to test it at work next Monday, I can't do so now either. I'll let you know, thank you |
|
CLAs look good, thanks! |
|
Tested & working! |
|
Thanks! Merged: c989a7e |
Fixes #1297
The new option allows to download the 32-bit version of the IE driver on
a 64-bit system, as the 64-bit version has been broken for over a year
now (the sendKeys() function works very slowly on it).