Placeholder injection mitigation unsafe placeholders #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…placeholders to use this property To prepare for extending the placeholder syntax to include unsafe placeholders, we are introducing a type property to manage and be the single source of truth about what type of placeholder is being used to make extensions to the syntax easier to maintain and write. We are assuming that a placeholder can only ever be of one type, and that union types are forbidden (e.g. unsafe and conditional placeholders are not allowed)
adds unsafe placeholder type for placeholders with the pattern `((<value>::unsafe))` as well as a stub replacement rule to check that unsafe placeholders are parsed correctly. This is to ensure we are ready for the next ticket, adding specific logic to implement the sanitisation of markdown.
…ighting appears correct we were incorrectly using the placeholder styling before. This styling was designed to ignore trailing parentheses when highlighting the placeholder's variable name. This new css class ensures the highlighting works correcly for unsafe placeholders where the variable doesn't have trailing parentheses
Any of the following characters: `*_(){}[]<>#+-.!| are escaped with a / to ensure they aren't rendered by the markdown engine to links, headings etc
… is found in a replacement value For the first iteration the simplest way to sanitise values containing a link is to consider the entire link compromised and redact everything in the value. This will require user testing as it may be more agressive sanitisation than users expect
Remove urls from unsafe placeholders
…_mitigation_unsafe_placeholders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.