Remove overall daily limit cache key #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quis
force-pushed
the
remove-overall-daily-limit-cache-key
branch
3 times, most recently
from
1301d00 to
699a7ad
Compare
As of https://github.com/alphagov/notifications-api/pull/4479/files we are no longer using this key – `notification_type` is always required
quis
force-pushed
the
remove-overall-daily-limit-cache-key
branch
from
699a7ad to
470c635
Compare
CrystalPea
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of alphagov/notifications-api#4479 we are no longer using this key –
notification_typeis always requiredThe apps already provide this argument: https://github.com/search?q=org%3Aalphagov+daily_limit_cache_key&type=code
So while this is technically a breaking change, it shouldn’t require updating any apps.