Add govuk app promo to sign-in page #5035
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| @import "govuk_publishing_components/individual_component_support"; | ||
|
|
||
| .app-promo { | ||
| padding-top: govuk-spacing(6); | ||
| border-top: 4px solid $govuk-brand-colour; | ||
| margin-top: govuk-spacing(8); | ||
|
|
||
| @include govuk-media-query($from: "tablet") { | ||
| margin-top: govuk-spacing(9); | ||
| } | ||
|
|
||
| .gem-c-image-card { | ||
| display: flex; | ||
| margin-bottom: 0; | ||
| } | ||
|
|
||
| .gem-c-image-card__description { | ||
| text-wrap: balance; | ||
| } | ||
|
|
||
| .gem-c-image-card__image-wrapper.gem-c-image-card__image-wrapper--one-third { | ||
| flex-basis: 100px; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| <% | ||
| add_view_stylesheet("sign-in") | ||
| # These components aren't found in the templates, but the styles are still | ||
| # needed as they're used within the sign in page's `content_item`. | ||
| add_gem_component_stylesheet("document-list") | ||
|
|
@@ -71,5 +72,23 @@ | |
| text: t("help.sign_in.search_for_a_service_button"), | ||
| secondary_solid: true %> | ||
| </form> | ||
|
|
||
| <div class="govuk-!-width-full app-promo"> | ||
| <%= render "govuk_publishing_components/components/image_card", { | ||
| two_thirds: true, | ||
| href: "/guidance/download-the-govuk-app", | ||
| image_src: asset_path("app-promo/govuk-app-icon.png"), | ||
| heading_text: "Get the GOV.UK app", | ||
| description: "Your government services and information, on the go.", | ||
|
There was a problem hiding this comment. We could add these to the locale files, but it might not be necessary now since we don’t know how long the promo will run. There was a problem hiding this comment. Thanks, I've added this suggestion to the image card component improvement ticket. |
||
| data_attributes: { | ||
| module: "ga4-link-tracker", | ||
| ga4_link: { | ||
| event_name: "navigation", | ||
| type: "image card", | ||
| }, | ||
| }, | ||
| } %> | ||
| </div> | ||
|
|
||
| </div> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that including text balance might be useful here, though it’s definitely not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've made this change as suggested