Add govuk app promo to sign-in page #5035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
changed the title
MartinJJones
force-pushed
the
add-app-promo-to-sign-in-page
branch
from
c587150 to
cdd9290
Compare
MartinJJones
force-pushed
the
add-app-promo-to-sign-in-page
branch
from
cd1cc67 to
88faf5c
Compare
MartinJJones
force-pushed
the
add-app-promo-to-sign-in-page
branch
from
88faf5c to
997533c
Compare
|
LGTM 🚀 |
MartinJJones
force-pushed
the
add-app-promo-to-sign-in-page
branch
from
997533c to
3e1495b
Compare
MartinJJones
force-pushed
the
add-app-promo-to-sign-in-page
branch
from
3e1495b to
da70cdf
Compare
MartinJJones
force-pushed
the
add-app-promo-to-sign-in-page
branch
from
da70cdf to
4c5fe2e
Compare
MartinJJones
changed the title
jon-kirwan
approved these changes
Oct 6, 2025
| href: "/guidance/download-the-govuk-app", | ||
| image_src: asset_path("app-promo/govuk-app-icon.png"), | ||
| heading_text: "Get the GOV.UK app", | ||
| description: "Your government services and information, on the go.", |
There was a problem hiding this comment.
We could add these to the locale files, but it might not be necessary now since we don’t know how long the promo will run.
There was a problem hiding this comment.
Thanks, I've added this suggestion to the image card component improvement ticket.
| .gem-c-image-card__image-wrapper.gem-c-image-card__image-wrapper--one-third { | ||
| flex-basis: 100px; | ||
| } | ||
| } |
There was a problem hiding this comment.
Just noting that including text balance might be useful here, though it’s definitely not required.
.gem-c-image-card__description {
text-wrap: balance;
}There was a problem hiding this comment.
Thanks, I've made this change as suggested
Add a new section to the sign-in page to promote the govuk app, including link tracking. A new sign-in view stylesheet is included to style the new app promo section, this includes some overrides to the default style of the image card component.
MartinJJones
force-pushed
the
add-app-promo-to-sign-in-page
branch
from
4c5fe2e to
f8c1474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a new section to the sign-in page to promote the govuk app, including link tracking.
A new sign-in view stylesheet is included to style the new app promo section, this includes some overrides to the default style of the image card component.
Why
Jira card: https://gov-uk.atlassian.net/browse/NAV-18518
Visual changes
Preview link: https://govuk-frontend-app-pr-5035.herokuapp.com/sign-in
Mobile
Desktop