Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/jobs/receive_submission_deliveries_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ def process_messages(sqs_client, queue_url, messages)

submission = Submission.find_by!(mail_message_id: ses_message_id)

process_delivery(submission)
delivery_time = Time.zone.parse(ses_message["delivery"]["timestamp"])
process_delivery(submission, delivered_at: delivery_time)
sqs_client.delete_message(queue_url: queue_url, receipt_handle: receipt_handle)

delivery_time = Time.zone.parse(ses_message["delivery"]["timestamp"])
submission_duration_ms = ((delivery_time - submission.created_at) * 1000).round
CloudWatchService.record_submission_delivery_latency_metric(submission_duration_ms, "Email")
rescue StandardError => e
Expand All @@ -74,9 +74,11 @@ def process_messages(sqs_client, queue_url, messages)
end
end

def process_delivery(submission)
def process_delivery(submission, **attributes)
set_submission_logging_attributes(submission)

submission.update! attributes

EventLogger.log_form_event("submission_delivered")
end
end
5 changes: 5 additions & 0 deletions spec/jobs/receive_submission_deliveries_job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@
))
end

it "saves the submission delivery time to the submission record" do
perform_enqueued_jobs
expect(submission.reload.delivered_at).to eq ses_delivery_timestamp
end

it "sends cloudwatch metric for submission delivery time" do
perform_enqueued_jobs
# latency is ses_delivery_timestamp - submission.created_at
Expand Down