Skip to content

Conversation

lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Oct 1, 2025

What problem does this pull request solve?

Keep a record of the message delivery time in our database for reference, so it's clear when inspecting submissions with the Rake task whether or not a submission has been delivered.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux force-pushed the ldeb-update-submission-delivered-at branch from 7d8a369 to b2fda3a Compare October 3, 2025 09:34
@lfdebrux lfdebrux force-pushed the ldeb-update-submission-delivered-at branch 2 times, most recently from ca14e3e to 6d4b8b7 Compare October 8, 2025 07:31
Keep a record of the message delivery time in our database for
reference, so it's clear when inspecting submissions with the Rake task
whether or not a submission has been delivered.
@lfdebrux lfdebrux force-pushed the ldeb-update-submission-delivered-at branch from 6d4b8b7 to 015e4d6 Compare October 8, 2025 12:39
Copy link

sonarqubecloud bot commented Oct 8, 2025

Copy link
Contributor

github-actions bot commented Oct 8, 2025

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants