txns: Uses sp.min_fee if available #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than use a hard coded constant for min_fee, use the one that is returned in SuggestedParams if available. Since some people may create a SuggestedParams by hand rather than get one from server (because our APIs require one even though the caller may feel they "know better"), continue to use the constant if the sp.min_fee is None.
jannotti
changed the title
jasonpaulos
reviewed
Jan 22, 2024
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
This is a good change, and I'm currently doing something very similar to the javascript v3 branch (except there I'm willing to go a step further and require min fee in the suggested params object, since it's a new major version. I will probably leave the constant exposed, but it wouldn't be used internally at all)
jannotti
force-pushed
the
use-sp-min-fee
branch
from
a5ccc10 to
3fb89cd
Compare
jasonpaulos
approved these changes
Jan 22, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than use a hard coded constant for min_fee, use the one that is returned in SuggestedParams if available.
Since some people may create a SuggestedParams by hand rather than get one from server (because our APIs require one even though the caller may feel they "know better"), continue to use the constant if the sp.min_fee is None.
First noted by @plasmatech8 in #299