Change min fee from constant to suggested param #299
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not know what peoples thoughts are about this is since I did not receive a response from #284.
This PR changes the fee calculations for Transaction classes under future.transaction so that it uses
sp.min_feeinstead ofconstants.min_txn_feein calculations when flat_fee=false.Rationale:
suggested_params.min_fee *= 2rather than configuring flat fees.I tried running tests using
make docker-testbut it is excruciatingly slow for some reason, so I will think about that another time.