Simplify kafka client bootstrap server names and ports config #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jan 6, 2024
...ng-kafka/src/main/java/io/aklivity/zilla/runtime/binding/kafka/config/KafkaServerConfig.java
Outdated
Show resolved
Hide resolved
.../java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaOptionsConfigAdapter.java
Outdated
Show resolved
Hide resolved
...java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaClientDescribeFactory.java
Outdated
Show resolved
Hide resolved
...java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaClientDescribeFactory.java
Outdated
Show resolved
Hide resolved
...in/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaClientGroupFactory.java
Outdated
Show resolved
Hide resolved
...in/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaClientGroupFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaClientMetaFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaClientMetaFactory.java
Outdated
Show resolved
Hide resolved
...a.spec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/schema/kafka.schema.patch.json
Outdated
Show resolved
Hide resolved
...g-tls.spec/src/main/scripts/io/aklivity/zilla/specs/binding/tls/schema/tls.schema.patch.json
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Jan 7, 2024
| } | ||
| else if (binding.routes.size() == 1 && | ||
| binding.routes.get(0).matches() && | ||
| options == null) |
There was a problem hiding this comment.
We don't require options == null, right?
jfallows
requested changes
Jan 9, 2024
|
|
||
| return resolved; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please move this method to the end of the class and make private static.
| resolved = new InetSocketAddress(InetAddress.getByAddress(ipv6), destinationPortInet6); | ||
| break; | ||
| default: | ||
| throw new RuntimeException("Unexpected address kind"); |
There was a problem hiding this comment.
Let's return null for other address types instead of throwing an exception, so no need for default case.
jfallows
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a developer, I want to be able to copy and paste the bootstrap server host and port into zilla.yaml and not need to understand the details of tls server name or tcp host and port.
Fixes #619