Skip to content

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Jun 5, 2025

This drops the image size by 300Mb, since /opt/home.tar contained unwanted packages installed in ~/.local, whereas they should have been installed to /opt/conda. Using uv instead of pip should also speed up the build.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@848c3df). Learn more about missing BASE report.
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage        ?   71.20%           
=======================================
  Files           ?       99           
  Lines           ?     7379           
  Branches        ?        0           
=======================================
  Hits            ?     5254           
  Misses          ?     2125           
  Partials        ?        0           
Flag Coverage Δ
python-3.11 71.20% <ø> (?)
python-3.9 71.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas danielhollas marked this pull request as draft June 5, 2025 23:58
@danielhollas
Copy link
Contributor Author

danielhollas commented Jun 5, 2025

There is something wrong with the aiidalab_qe_vibroscopy package. uv refuses to install it, erroring about RECORD file. I can install it via pip, but then mamba list is broken, with the same issue.
I think the web of packages here has gotten really out of hand...

EDIT: aiidalab/aiidalab-qe-vibroscopy#147

@danielhollas
Copy link
Contributor Author

Blocked on aiidalab/aiidalab-qe-vibroscopy#147

@mikibonacci
Copy link
Member

Hi @danielhollas , now should be ok. Can you see if it works by changing here the two github values of the first two packages (vibroscopy and muon), to be https://github.com/aiidalab/[email protected] and https://github.com/aiidalab/[email protected]?
Thanks

@danielhollas
Copy link
Contributor Author

Thanks @mikibonacci. We're now running into another issue


6.735   × No solution found when resolving dependencies:
6.735   ╰─▶ Because only aiida-vibroscopy==1.2.0 is available and
6.735       aiida-vibroscopy==1.2.0 depends on spglib<2.5, we can conclude that all
6.735       versions of aiida-vibroscopy depend on spglib<2.5.
6.735       And because aiidalab-qe-vibroscopy==1.2.0 depends on aiida-vibroscopy
6.735       and only aiidalab-qe-vibroscopy==1.2.0 is available, we can conclude
6.735       that all versions of aiidalab-qe-vibroscopy depend on spglib<2.5.
6.735       And because you require spglib==2.5.0 and aiidalab-qe-vibroscopy, we can
6.735       conclude that your requirements are unsatisfiable.

Do you know why the spglib lib is pinned to v2.5.0 in the Dockerfile? It's doesn't seem to be compatible with aiida-vibroscopy.

@mikibonacci
Copy link
Member

Hi @danielhollas, I don't know. This is however strange: in the aiidalab/qe:v25.04.1, we have aiida-vibroscopy==1.2.0 and spglib==2.5.0, without issues. I wonder why now the issue is there. Maybe the order of packages installation changed?

Anyway, pinging @superstar54 and @edan-bainglass to see if they knows the reason of fixing the spglib version in the Dockerfile.

@danielhollas
Copy link
Contributor Author

I wonder why now the issue is there.

That's because in this PR, I am installing all the packages together in a single pip install invocation so the resolver rightfully complains that the dependencies cannot be resolved.

In the previous version might work, but the python environment is not consistent (you can verify that by running pip check.

@danielhollas
Copy link
Contributor Author

Do you know why the spglib lib is pinned to v2.5.0 in the Dockerfile?

The spglib pin has been added in #1282, but there's not comment about it in the PR.

@danielhollas
Copy link
Contributor Author

@edan-bainglass FYI the discussion here gives a small taste for the dependency issues I briefly mentioned on Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants