-
Notifications
You must be signed in to change notification settings - Fork 21
Don't install pypi packages to ~/.local #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1337 +/- ##
=======================================
Coverage ? 71.20%
=======================================
Files ? 99
Lines ? 7379
Branches ? 0
=======================================
Hits ? 5254
Misses ? 2125
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There is something wrong with the aiidalab_qe_vibroscopy package. uv refuses to install it, erroring about RECORD file. I can install it via pip, but then |
Blocked on aiidalab/aiidalab-qe-vibroscopy#147 |
Hi @danielhollas , now should be ok. Can you see if it works by changing here the two github values of the first two packages (vibroscopy and muon), to be |
Thanks @mikibonacci. We're now running into another issue
Do you know why the |
Hi @danielhollas, I don't know. This is however strange: in the Anyway, pinging @superstar54 and @edan-bainglass to see if they knows the reason of fixing the |
That's because in this PR, I am installing all the packages together in a single pip install invocation so the resolver rightfully complains that the dependencies cannot be resolved. In the previous version might work, but the python environment is not consistent (you can verify that by running |
The spglib pin has been added in #1282, but there's not comment about it in the PR. |
@edan-bainglass FYI the discussion here gives a small taste for the dependency issues I briefly mentioned on Friday. |
This drops the image size by 300Mb, since
/opt/home.tar
contained unwanted packages installed in~/.local
, whereas they should have been installed to/opt/conda
. Using uv instead of pip should also speed up the build.