Skip to content

Conversation

mikibonacci
Copy link
Member

@mikibonacci mikibonacci commented Apr 5, 2025

Hi @superstar54 , just putting the aiida-bader post install at the end of the RUN, because fails, I think then nothing will be executed (like the other post install). See https://github.com/aiidalab/aiidalab-qe/actions/runs/14280666542/job/40029931956#step:8:1714

just a quick fix. moreover, the bader@localhost seems to be already there, so I think it is ok just for now

@mikibonacci mikibonacci requested a review from superstar54 April 5, 2025 11:07
@mikibonacci mikibonacci marked this pull request as ready for review April 5, 2025 11:07
@superstar54
Copy link
Member

Hi @mikibonacci , thanks for pointting out this, the error related to bader plugin seems to be a general problem for all qeapp plugins.

I did a quick test locally, for wannier90

>>> from aiidalab_qe_wannier90 import wannier90
Failed to load plugin entry point wannier90.
This may be due to compatibility issues with the current QEApp version.
Please contact the plugin author for further assistance.
Thus, the plugin will not be available. However, you can still use the rest of the app.
Error message: partially initialized module 'aiidalab_qe_wannier90.wannier90' has no attribute 'wannier90' (most likely due to a circular import)

also for vibroscopy

>>> from aiidalab_qe_vibroscopy.app import property
Failed to load plugin entry point vibronic.
This may be due to compatibility issues with the current QEApp version.
Please contact the plugin author for further assistance.
Thus, the plugin will not be available. However, you can still use the rest of the app.
Error message: partially initialized module 'aiidalab_qe_vibroscopy.app' has no attribute 'property' (most likely due to a circular import)

The post-install of bader plugin also installs additional pseudos. Even though there is a error message, but the post-install script works as expected, so we need to keep it.

Still need more time to investigate the reason, but it does not affect the functionality of the app in the final image. So I suggest that we leave it for the future.

@superstar54
Copy link
Member

Make a note for the future, to reproduce the error

docker run -it ghcr.io/aiidalab/full-stack:2025.1026 /bin/bash

then install aiidalab-qe, then run this:

>>> from aiidalab_qe.plugins.pdos import pdos
Failed to load plugin entry point pdos.
This may be due to compatibility issues with the current QEApp version.
Please contact the plugin author for further assistance.
Thus, the plugin will not be available. However, you can still use the rest of the app.
Error message: partially initialized module 'aiidalab_qe.plugins.pdos' has no attribute 'pdos' (most likely due to a circular import)

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikibonacci mikibonacci merged commit bbce9db into main Apr 5, 2025
8 of 9 checks passed
@mikibonacci mikibonacci deleted the fix/scipy-conda branch April 5, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants