test: プロジェクト読み込みのテストを追加 #2732

sevenc-nanashi · 2025-09-06T22:34:29Z

内容

タイトル通りです。
また、一部細かい調整（内部で使われている識別名の変更など）も行っています。

スクリーンショット・動画など

（なし）

その他

voicevox-preview-pages · 2025-09-06T22:38:13Z

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ：b80bddc

tests/e2e/browser/mockUtility.ts

Hiroshiba · 2025-09-07T05:24:33Z

@codex このプルリクエストをレビューしてください

chatgpt-codex-connector

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

tests/e2e/browser/vvproj/simple.vvproj

Hiroshiba · 2025-09-07T11:37:30Z

tests/e2e/browser/vvproj/future.vvproj

@@ -0,0 +1 @@
+{"appVersion":"9999.9999.9999","talk":{"audioKeys":["b52d172e-44b8-4d2e-b184-cda49015ccf7","0bfa1591-8e39-400d-a1fa-90d5f2202372","4a9b9b66-7a5b-415e-9730-7cbcc02ed5e2"],"audioItems":{"b52d172e-44b8-4d2e-b184-cda49015ccf7":{"text":"hoge","voice":{"engineId":"074fc39e-678b-4c13-8916-ffca8d505d1d","speakerId":"7ffcb7ce-00ec-4bdc-82cd-45a8889e43ff","styleId":0},"query":{"accentPhrases":[],"speedScale":1,"pitchScale":0,"intonationScale":1,"volumeScale":1,"prePhonemeLength":0.1,"postPhonemeLength":0.1,"pauseLength":null,"pauseLengthScale":1,"outputSamplingRate":24000,"outputStereo":false},"presetKey":"2e2dc222-3218-41bf-b68c-5a863d9ddd53"},"0bfa1591-8e39-400d-a1fa-90d5f2202372":{"text":"fuga","voice":{"engineId":"074fc39e-678b-4c13-8916-ffca8d505d1d","speakerId":"388f246b-8c41-4ac1-8e2d-5d79f3ff56d9","styleId":1},"query":{"accentPhrases":[],"speedScale":1,"pitchScale":0,"intonationScale":1,"volumeScale":1,"prePhonemeLength":0.1,"postPhonemeLength":0.1,"pauseLength":null,"pauseLengthScale":1,"outputSamplingRate":24000,"outputStereo":false},"presetKey":"ca0ba6ba-558a-4b46-a201-3a266a4da90e"},"4a9b9b66-7a5b-415e-9730-7cbcc02ed5e2":{"text":"piyo","voice":{"engineId":"074fc39e-678b-4c13-8916-ffca8d505d1d","speakerId":"35b2c544-660e-401e-b503-0e14c635303a","styleId":8},"query":{"accentPhrases":[],"speedScale":1,"pitchScale":0,"intonationScale":1,"volumeScale":1,"prePhonemeLength":0.1,"postPhonemeLength":0.1,"pauseLength":null,"pauseLengthScale":1,"outputSamplingRate":24000,"outputStereo":false},"presetKey":"56d5633e-b015-4403-baea-9338a2789db5"}}},"song":{"tpqn":480,"tempos":[{"position":0,"bpm":120}],"timeSignatures":[{"measureNumber":1,"beats":4,"beatType":4}],"tracks":{"7dc46a6b-3429-45e8-9c40-160c18516238":{"name":"無名トラック","keyRangeAdjustment":0,"volumeRangeAdjustment":0,"notes":[],"pitchEditData":[],"phonemeTimingEditData":{},"solo":false,"mute":false,"gain":1,"pan":0}},"trackOrder":["7dc46a6b-3429-45e8-9c40-160c18516238"]}}


このファイル、プロジェクトファイルのマイグレーションをしてくれないから、データ構造変わるたびに更新する必要があってしんどいかも？
空のプロジェクトファイルを作る関数を呼ぶと良いかも。
可能ならjson stringにする関数も共通化したいけど、Vuex storeにしかないならまずそれを切り出す必要があるかも。

ここはappVersionさえ読めればなんでもいいはずですね。

あ、なるほどです。
んじゃappVersionだけがキーなプロジェクトファイルにすると良さそう？

tests/e2e/browser/vvproj/simple.vvproj

sevenc-nanashi · 2025-09-08T06:30:59Z

ちょっと色々触ってたんですが、多分プロジェクトファイルを作成して保存してから読み込むみたいな流れの方が楽な気がしてきたのでいったんDraftにします。

sevenc-nanashi · 2025-09-08T07:15:57Z

保存->読み込みにしました。

Copilot

Pull Request Overview

プロジェクト読み込みに関するE2Eテストを追加し、関連する識別名の変更を行うPRです。

E2Eテストで過去・未来のプロジェクトファイル読み込みとプロジェクト保存・再読み込みのテストを追加
showOldProjectWarningDialogからshowNewerVersionWarningDialogへの識別名変更とメッセージ更新
テスト用ユーティリティ関数の共通化とファイル操作モック関数の追加

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/unit/domain/project.spec.ts	未来バージョン警告ダイアログ関数名とテスト期待値を新しい識別名に更新
tests/e2e/browser/プロジェクト.spec.ts	プロジェクト読み込み・保存・未来バージョン警告のE2Eテストを新規追加
tests/e2e/browser/テキスト追加・削除・入れ替え.spec.ts	重複するヘルパー関数を削除し、共通のutils関数を使用するよう変更
tests/e2e/browser/vvproj/simple.vvproj	テスト用の基本プロジェクトファイルを追加
tests/e2e/browser/vvproj/future.vvproj	未来バージョンテスト用のプロジェクトファイルを追加
tests/e2e/browser/utils.ts	プロジェクト操作とAudioCell操作の共通ユーティリティ関数を新規追加
tests/e2e/browser/mockUtility.ts	ファイル読み込みとファイル選択ダイアログのモック関数を追加
src/store/project/index.ts	警告ダイアログ関数名とタイトルメッセージを更新
src/infrastructures/projectFile/migration.ts	警告ダイアログ関数名と戻り値の識別名を更新

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Hiroshiba · 2025-09-09T14:55:40Z

@codex このプルリクエストを日本語でレビューしてください。

chatgpt-codex-connector

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

tests/e2e/browser/utils.ts

tests/e2e/browser/vvproj/simple.vvproj

Hiroshiba

fillAudioCellとかをutilsに再配置するの良いですね！！

ほぼLGTMです！！
細かいとこだけ･･･！

tests/e2e/browser/utils.ts

src/infrastructures/projectFile/migration.ts

Hiroshiba

いろいろ書いてますがLGTM！！

test.stepで区切っていくのめっちゃいいですねぇ。
やりたいことがわかる。

src/infrastructures/projectFile/migration.ts

tests/e2e/browser/utils.ts

tests/e2e/browser/プロジェクト.spec.ts

Co-authored-by: Hiroshiba <[email protected]>

sevenc-nanashi · 2025-09-18T00:04:02Z

マージします。

sevenc-nanashi added 2 commits September 7, 2025 07:31

test: 未来のバージョンで作られたファイルの警告のテストを追加

b4343d8

chore: テキストをちょっと変える

5f53e39

sevenc-nanashi requested a review from a team as a code owner September 6, 2025 22:34

sevenc-nanashi requested review from Hiroshiba and removed request for a team September 6, 2025 22:34

fix: testのリテラルを修正

fcaa439

sevenc-nanashi requested a review from Copilot September 6, 2025 23:01

This comment was marked as outdated.

Sign in to view

Hiroshiba reviewed Sep 7, 2025

View reviewed changes

tests/e2e/browser/mockUtility.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Sep 7, 2025

View reviewed changes

tests/e2e/browser/vvproj/simple.vvproj Outdated Show resolved Hide resolved

chore: デバッグログを消す

6cd2573

Hiroshiba reviewed Sep 7, 2025

View reviewed changes

tests/e2e/browser/vvproj/simple.vvproj Outdated Show resolved Hide resolved

sevenc-nanashi marked this pull request as draft September 8, 2025 06:31

sevenc-nanashi added 2 commits September 8, 2025 15:33

chore: 0.24.2に固定する

74445c4

chore: 保存->読み込みにする

b6397e7

sevenc-nanashi changed the title ~~test: 未来のバージョンで作られたファイルの警告のテストを追加~~ test: プロジェクト読み込みのテストを追加 Sep 8, 2025

sevenc-nanashi marked this pull request as ready for review September 8, 2025 07:16

Hiroshiba requested a review from Copilot September 9, 2025 14:55

Copilot AI reviewed Sep 9, 2025

View reviewed changes

chatgpt-codex-connector bot reviewed Sep 9, 2025

View reviewed changes

tests/e2e/browser/utils.ts Outdated Show resolved Hide resolved

chore: test.expect -> expect

a5a8eac

Hiroshiba reviewed Sep 14, 2025

View reviewed changes

tests/e2e/browser/vvproj/simple.vvproj Outdated Show resolved Hide resolved

Hiroshiba reviewed Sep 14, 2025

View reviewed changes

tests/e2e/browser/utils.ts Outdated Show resolved Hide resolved

tests/e2e/browser/utils.ts Outdated Show resolved Hide resolved

tests/e2e/browser/utils.ts Outdated Show resolved Hide resolved

chore: paramsとreturnsを増やす

fcc264f

sevenc-nanashi added 3 commits September 17, 2025 06:52

chore: 0.14.11.vvprojにする

0937b90

fix: テストが落ちてるのを修正

1675344

style: nr fmt

71cbbcd

sevenc-nanashi commented Sep 17, 2025

View reviewed changes

src/infrastructures/projectFile/migration.ts Show resolved Hide resolved

Hiroshiba approved these changes Sep 17, 2025

View reviewed changes

sevenc-nanashi and others added 3 commits September 17, 2025 22:55

chore: TODOを詳しく

3313ee9

Co-authored-by: Hiroshiba <[email protected]>

chore: WHYを追記

279bb71

Co-authored-by: Hiroshiba <[email protected]>

chore: assertNonNullableを使う

b80bddc

sevenc-nanashi requested a review from Hiroshiba September 17, 2025 14:00

Hiroshiba approved these changes Sep 17, 2025

View reviewed changes

sevenc-nanashi enabled auto-merge September 18, 2025 00:04

sevenc-nanashi added this pull request to the merge queue Sep 18, 2025

Merged via the queue into VOICEVOX:main with commit 4630c08 Sep 18, 2025
11 checks passed

		@@ -0,0 +1 @@
		{"appVersion":"9999.9999.9999","talk":{"audioKeys":["b52d172e-44b8-4d2e-b184-cda49015ccf7","0bfa1591-8e39-400d-a1fa-90d5f2202372","4a9b9b66-7a5b-415e-9730-7cbcc02ed5e2"],"audioItems":{"b52d172e-44b8-4d2e-b184-cda49015ccf7":{"text":"hoge","voice":{"engineId":"074fc39e-678b-4c13-8916-ffca8d505d1d","speakerId":"7ffcb7ce-00ec-4bdc-82cd-45a8889e43ff","styleId":0},"query":{"accentPhrases":[],"speedScale":1,"pitchScale":0,"intonationScale":1,"volumeScale":1,"prePhonemeLength":0.1,"postPhonemeLength":0.1,"pauseLength":null,"pauseLengthScale":1,"outputSamplingRate":24000,"outputStereo":false},"presetKey":"2e2dc222-3218-41bf-b68c-5a863d9ddd53"},"0bfa1591-8e39-400d-a1fa-90d5f2202372":{"text":"fuga","voice":{"engineId":"074fc39e-678b-4c13-8916-ffca8d505d1d","speakerId":"388f246b-8c41-4ac1-8e2d-5d79f3ff56d9","styleId":1},"query":{"accentPhrases":[],"speedScale":1,"pitchScale":0,"intonationScale":1,"volumeScale":1,"prePhonemeLength":0.1,"postPhonemeLength":0.1,"pauseLength":null,"pauseLengthScale":1,"outputSamplingRate":24000,"outputStereo":false},"presetKey":"ca0ba6ba-558a-4b46-a201-3a266a4da90e"},"4a9b9b66-7a5b-415e-9730-7cbcc02ed5e2":{"text":"piyo","voice":{"engineId":"074fc39e-678b-4c13-8916-ffca8d505d1d","speakerId":"35b2c544-660e-401e-b503-0e14c635303a","styleId":8},"query":{"accentPhrases":[],"speedScale":1,"pitchScale":0,"intonationScale":1,"volumeScale":1,"prePhonemeLength":0.1,"postPhonemeLength":0.1,"pauseLength":null,"pauseLengthScale":1,"outputSamplingRate":24000,"outputStereo":false},"presetKey":"56d5633e-b015-4403-baea-9338a2789db5"}}},"song":{"tpqn":480,"tempos":[{"position":0,"bpm":120}],"timeSignatures":[{"measureNumber":1,"beats":4,"beatType":4}],"tracks":{"7dc46a6b-3429-45e8-9c40-160c18516238":{"name":"無名トラック","keyRangeAdjustment":0,"volumeRangeAdjustment":0,"notes":[],"pitchEditData":[],"phonemeTimingEditData":{},"solo":false,"mute":false,"gain":1,"pan":0}},"trackOrder":["7dc46a6b-3429-45e8-9c40-160c18516238"]}}

test: プロジェクト読み込みのテストを追加 #2732

test: プロジェクト読み込みのテストを追加 #2732

Uh oh!

Conversation

sevenc-nanashi commented Sep 6, 2025

内容

関連 Issue

スクリーンショット・動画など

その他

Uh oh!

voicevox-preview-pages bot commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Hiroshiba commented Sep 7, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Hiroshiba Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Hiroshiba Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

sevenc-nanashi Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Hiroshiba Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sevenc-nanashi commented Sep 8, 2025

Uh oh!

sevenc-nanashi commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Hiroshiba commented Sep 9, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Hiroshiba left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hiroshiba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sevenc-nanashi commented Sep 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

voicevox-preview-pages bot commented Sep 6, 2025 •

edited

Loading

sevenc-nanashi commented Sep 8, 2025 •

edited

Loading

Hiroshiba left a comment •

edited

Loading