Skip to content

Conversation

@sevenc-nanashi
Copy link
Member

内容

タイトル通りです。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner September 6, 2025 08:26
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team September 6, 2025 08:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds type checking for button color specification in QuestionDialog components. The changes introduce a strict type union QuestionDialogButtonColor to ensure only valid color values ("display", "primary", "warning") can be used for dialog buttons.

  • Adds QuestionDialogButtonColor type definition with allowed color values
  • Updates QuestionDialog component to use typed button colors instead of generic strings
  • Replaces generic error handling with ExhaustiveError for better type safety
  • Updates existing usage to use valid "warning" color instead of "danger"

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/components/Dialog/Dialog.ts Defines the new QuestionDialogButtonColor type and updates QuestionDialogOptions interface
src/components/Dialog/TextDialog/QuestionDialog.vue Updates component props and logic to use the new typed color system
src/store/project/index.ts Changes button color from "danger" to "warning" to match the new type constraints

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:79e89b6

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

e2eテスト書いても良いかも?

@sevenc-nanashi
Copy link
Member Author

今のところプロジェクト読み込みはモックできていない、かつ結構大きくなりそうなのでこのプルリクはいったんマージして別のPRでやろうと思います。

というわけでマージします。

@sevenc-nanashi sevenc-nanashi added this pull request to the merge queue Sep 6, 2025
Merged via the queue into VOICEVOX:main with commit 5c7700a Sep 6, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants